Bug 11843 - [S60] Links on www.sonera.fi don't work and open floating Toolbar
Summary: [S60] Links on www.sonera.fi don't work and open floating Toolbar
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 420+
Hardware: S60 Emulator S60 3rd edition
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-15 12:49 PST by Rasvan Alexandrescu
Modified: 2011-03-21 11:52 PDT (History)
0 users

See Also:

Attachments
KeyEventHandler modified to look for any node under pointer (1.37 KB, patch)
2006-12-15 12:57 PST, Rasvan Alexandrescu 		Sachin.Padma: review-
Details | Formatted Diff | Diff
variable for element type added (5.59 KB, patch)
2006-12-18 15:50 PST, Rasvan Alexandrescu 		Sachin.Padma: review-
Details | Formatted Diff | Diff
added Sachin's comments (5.34 KB, patch)
2006-12-20 10:01 PST, Rasvan Alexandrescu 		yongjun.zhang: review+
Details | Formatted Diff | Diff
3.1 patch (5.36 KB, patch)
2006-12-20 14:47 PST, Rasvan Alexandrescu 		yongjun.zhang: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rasvan Alexandrescu 2006-12-15 12:49:52 PST 
[S60]Links on webpage http://www.sonera.fi don't work and clicking a link just opens browsing Toolbar.
Comment 1 Rasvan Alexandrescu 2006-12-15 12:57:22 PST 
Created attachment 11868 [details]
KeyEventHandler modified to look for any node under pointer
Comment 2 Sachin Padma 2006-12-18 07:15:24 PST 
Comment on attachment 11868 [details]
KeyEventHandler modified to look for any node under pointer

FocusedElementType should have returned as anchor instead of none.
Comment 3 Rasvan Alexandrescu 2006-12-18 08:42:06 PST 
For this particular case would work, but what if we have as a node an input box or any selection button or mail anchor, etc ? The toolbar will have priority over the node functionality which contradicts the specification. The solution I proposed covers all this cases.
Comment 4 Rasvan Alexandrescu 2006-12-18 15:50:38 PST 
Created attachment 11909 [details]
variable for element type added

variable for element type added to the keyeventhandler
Comment 5 Sachin Padma 2006-12-20 08:30:22 PST 
Comment on attachment 11909 [details]
variable for element type added

You can just check if iElType == TBrCtlDefs::EElementNone when activating second time.
Comment 6 Rasvan Alexandrescu 2006-12-20 10:01:33 PST 
Created attachment 11937 [details]
added Sachin's comments
Comment 7 Rasvan Alexandrescu 2006-12-20 14:47:31 PST 
Created attachment 11939 [details]
3.1 patch
Comment 8 Yongjun Zhang 2006-12-20 14:49:10 PST 
Comment on attachment 11939 [details]
3.1 patch

r=me
Comment 9 Yongjun Zhang 2006-12-20 15:07:07 PST 
Comment on attachment 11937 [details]
added Sachin's comments

r=me
Comment 10 Yongjun Zhang 2006-12-20 15:08:20 PST 
Completed: At revision: 18363
Comment 11 Krishna 2006-12-22 09:56:23 PST 
MHAE-6WEJCH 

Verified and Closed.
Comment 12 Joel Parks 2011-03-21 11:52:57 PDT 
re-purposing InTSW keyword for use by QtWebkit team