Bug 11820 – Make the Windows port compile again

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Brett Wilson (Google)]

The windows build is busted again.

[Brett Wilson (Google)]

Created attachment 11833 [details]
Fix windows build bustage as of r18196

This patch makes the Windows build compile and run again. As part of this, I moved some of the Windows-specific callback clients from WebCore to WebKit where they belong. These are the *Client files, which I created files mirroring the Mac structure for them that are currently empty, and moved the implementations out of TemporaryLinkStubs, because that's WebCore only.

[Darin Adler]

Comment on attachment 11833 [details]
Fix windows build bustage as of r18196

The change to FormState.h is incorrect. People who manipulate FormState objects do need to include HTMLFormElement.h, but FormState.h itself does not. You can successfully call values() on a FormState object without ever including HTMLFormElement.h for example.

The rest of this looks OK.

[Brett Wilson (Google)]

Created attachment 11847 [details]
Address comments, fix Windows build bustage as of r18218

This addresses the review comments about FormState.h, and I also added a few more things to TemporaryLinkStubs to fix things that were broken since I uploaded that last patch.

[Brett Wilson (Google)]

Created attachment 11866 [details]
New patch to fix Windows build bustage up to r18233

Updated patch. Exactly one line changed from previous patch, PopupMenu::PopupMenu in TemporaryLinkStubs changed.

[Alexey Proskuryakov]

Comment on attachment 11866 [details]
New patch to fix Windows build bustage up to r18233

r=me

+#pragma warning(push, 0)

It's sad that these are needed, but removing them can wait.

[Brett Wilson (Google)]

Created attachment 11867 [details]
diff of Spinneret.sln from previous patch

[Alexey Proskuryakov]

Committed revision 18236.