Bug 11809 - fast/dom/gc-8.html crash in alternate-thread marking code in ScriptInterpreter
Summary: fast/dom/gc-8.html crash in alternate-thread marking code in ScriptInterpreter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Critical
Assignee: Darin Adler
URL:
Keywords: LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2006-12-11 19:37 PST by Brady Eidson
Modified: 2006-12-12 00:17 PST (History)
1 user (show)

See Also:


Attachments
Crash log for the layout test gc-8.html (4.91 KB, text/plain)
2006-12-11 19:40 PST, Brady Eidson
no flags Details
patch, including debug harness I used to diagnose and test (10.78 KB, patch)
2006-12-11 23:19 PST, Darin Adler
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2006-12-11 19:37:01 PST
While working on a large patch, I started to see fast/dom/gc-8.html fail with some regularity.  Talking with a few other members of the WebKit team I've learn that others have seen it anywhere from occasionally to regularly, as well.

I'm attaching the stack trace but I can't capture this in the debugger - the test by itself seems to not fail, and adding tests before it to cause its failure is more of an art than a science.
Comment 1 Brady Eidson 2006-12-11 19:40:12 PST
Created attachment 11813 [details]
Crash log for the layout test gc-8.html

fast/dom/gc-8.html crash log, here you go!  To repro this, I simply ran run-webkit-tests fast/dom - it crashes about 2/3 the way through the top level directory
Comment 2 Darin Adler 2006-12-11 21:55:02 PST
I've been seeing the same crash.
Comment 3 Dave Hyatt 2006-12-11 21:56:27 PST
Did anyone see this before I landed the ICU abstraction?  I'm suspicious of that change now even though the crash log looks unrelated.

Comment 4 Brady Eidson 2006-12-11 22:02:36 PST
While the first time I ever saw this problem was today, I haven't updated since Thursday, so the ICU abstraction is out for my tree...
Comment 5 Brady Eidson 2006-12-11 22:07:07 PST
lemme amend and clarify my statement - I'm running on 18092 + local mods.  Hyatt landed the ICU abstraction in 18098. 
Comment 6 Darin Adler 2006-12-11 23:19:06 PST
Created attachment 11814 [details]
patch, including debug harness I used to diagnose and test
Comment 7 Geoffrey Garen 2006-12-11 23:24:47 PST
Comment on attachment 11814 [details]
patch, including debug harness I used to diagnose and test

r=me
Comment 8 Darin Adler 2006-12-11 23:52:49 PST
Committed revision 18171.
Comment 9 Alexey Proskuryakov 2006-12-12 00:17:51 PST
Marking as fixed.