RESOLVED FIXED 11807
Merge EventHandler::m_bMousePressed and EventHandler::m_mousePressed 
https://bugs.webkit.org/show_bug.cgi?id=11807
Summary Merge EventHandler::m_bMousePressed and EventHandler::m_mousePressed
Alexey Proskuryakov
Reported 2006-12-11 11:49:43 PST
First part of bug 11784 - making baby steps to simplify future regression testing :) Merging these variables uncovered an issue with event handling in DRT. Mouse clicks in native widgets would turn [NSApp currentEvent] from nil to NSLeftMouseUp forever, so lastEventIsMouseUp() started to misbehave and caused m_mouseDown to be reset to false in handleMousePressed(). I couldn't find any way to work around this issue in DRT, so I had to change WebCore (added a check to event timestamps). Luckily, the impact seems to be minor.
Attachments
proposed patch (5.00 KB, patch)
2006-12-11 11:59 PST, Alexey Proskuryakov 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2006-12-11 11:59:10 PST
Created attachment 11804 [details] proposed patch
Adam Roben (:aroben)
Comment 2 2006-12-11 12:01:44 PST
Comment on attachment 11804 [details] proposed patch r=me
Alexey Proskuryakov
Comment 3 2006-12-11 12:27:06 PST
Committed revision 18158.
Note You need to log in before you can comment on or make changes to this bug.