Bug 11801 – Autogenerate POD types in Objc/JS generation

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Nikolas Zimmermann]

Currently we have three hand-written bindings, SVGPoint/SVGRect/SVGNumber, living in WebCore/bindings/js and WebCore/bindings/objc. They work around the fact that our wrapper generation assumes to operate on refcounted impl objects (ie. RefPtr<SVGNumber> m_impl). For efficiency we do NOT pass around SVGRect/SVGPoint/SVGNumber pointers around anymore in ksvg2. That's why we need a different style of Js/ObjC wrapper, those who operate on POD types.

Basically the attached patch "models" the hand-written generators as they are right now, but automatically using CodeGeneratorJS.pm / CodeGeneratorObjC.pm. This will help a lot in near future, when we also want to convert SVGAngle/SVGPreserveAspectRatio/SVGMatrix/SVGLength to POD types.

[Nikolas Zimmermann]

Created attachment 11801 [details]
Initial patch

This patch autogenerates DOMSVGNumber/DOMSVGRect/DOMSVGPoint, and JSSVGNumber/JSSVGRect/JSSVGPoint. The only limitation is that currently the "matrixTransform" method of SVGPoint.idl had to be disabled, it can only work with Rob's SVGMatrix -> AffineTransform patch.

If this patch gets positive review, we have to wait for Rob's patch to also get r+, and then land both together otherwhise the matrixTransform() layout test would be broken. Hope that's fine...

[Nikolas Zimmermann]

Created attachment 11802 [details]
Updated patch

Fix the issue after weinigs first review...

[Sam Weinig]

Comment on attachment 11802 [details]
Updated patch

Looks great!

[Nikolas Zimmermann]

Landed in r18153.