Bug 11798 – [CSS 3] missing cursor support for 'none'

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Lars Næsbye Christensen]

The only cursor selector we lack is the 'none' cursor, which in effect should be invisible (done here with PNG transparency).

[Lars Næsbye Christensen]

Created attachment 11793 [details]
patch to support CSS 3 'none' cursor selector

[Darin Adler]

Comment on attachment 11793 [details]
patch to support CSS 3 'none' cursor selector

Looks fine for Mac, but I'd like to see a patch that keeps the other platforms compiling too.

[Darin Adler]

Comment on attachment 11793 [details]
patch to support CSS 3 'none' cursor selector

Marking review- just because of the "no changes for the other platforms" issue. Please submit a patch that at least tries to keep all the platforms working.

[Lars Næsbye Christensen]

Created attachment 11848 [details]
patch v2 - with more platforms

Point taken. This should at least provide some default results.

[Alexey Proskuryakov]

Comment on attachment 11848 [details]
patch v2 - with more platforms

r=me

Qt has BlankCursor; I'm going to tweak the patch to use it instead of pointer when landing.

[Lars Næsbye Christensen]

(In reply to comment #5)
That sounds nice :-)

And yes, I should be more mindful about making sure they all compile.

[Alexey Proskuryakov]

Committed revision 18270.

I also had to fix cssparser.cpp: when changing CSS value IDs, one needs to make sure that the calculations are still correct. This patch broke border/outline properties entirely, and an earlier cursor patch broke -webkit-background-composite: copy.

What do you think about adding support for Mozilla cursors (bug 8988)? I'm not sure what our policy on Mozilla CSS extensions is (currently, we don't support any -moz- properties), but those cursors look pretty useful.

[Lars Næsbye Christensen]

(In reply to comment #7)

Well, unless there's a general attitude against them, I don't see why we shouldn't include them. It'd be a pleasure. As far as I can see, it's the grab/grabbing and zoom in/out cursors we need to add.

However, I spotted that some of the existing cursor images have bad transparency and other issues. Also, we could really do with a more modern, OSX-ish set of cursors generally. 16x16 B/W and no drop shadows? We can do better, and I think that's priority #1 :-)