Bug 11794 - fix lifetime problems affecting Frame's ownerElement pointer
Summary: fix lifetime problems affecting Frame's ownerElement pointer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-09 14:39 PST by Darin Adler
Modified: 2006-12-11 22:30 PST (History)
1 user (show)

See Also:


Attachments
patch, no change log yet (56.32 KB, patch)
2006-12-09 14:40 PST, Darin Adler
no flags Details | Formatted Diff | Diff
patch with change log (63.16 KB, patch)
2006-12-11 15:18 PST, Darin Adler
beidson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2006-12-09 14:39:28 PST
Brady ran into some crashes while doing his history work. At the bottom are problems with the lifetime of the Frame's ownerElement pointer. I have a patch to address this.
Comment 1 Darin Adler 2006-12-09 14:40:05 PST
Created attachment 11792 [details]
patch, no change log yet
Comment 2 Darin Adler 2006-12-11 15:18:51 PST
Created attachment 11810 [details]
patch with change log
Comment 3 Brady Eidson 2006-12-11 15:52:55 PST
Comment on attachment 11810 [details]
patch with change log

Fix the ChangeLog merging madness, and r=me
Comment 4 Darin Adler 2006-12-11 15:53:40 PST
Committed revision 18163.
Comment 5 David Kilzer (:ddkilzer) 2006-12-11 16:45:40 PST
It appears that this change caused a layout test regression:

fast/frames/iframe-option-crash

http://build.webkit.org/results/post-commit-powerpc-mac-os-x/4654/
http://build.webkit.org/post-commit-powerpc-mac-os-x/builds/4654/step-layout-test/0
Comment 6 Darin Adler 2006-12-11 17:27:50 PST
(In reply to comment #5)
> It appears that this change caused a layout test regression:
> 
> fast/frames/iframe-option-crash
> 
> http://build.webkit.org/results/post-commit-powerpc-mac-os-x/4654/
> http://build.webkit.org/post-commit-powerpc-mac-os-x/builds/4654/step-layout-test/0

Darn.

I don't think this is a real regression -- I think I just need to update this test result. The point of the test is to check if you crash.

I'll try to get to this tonight.
Comment 7 David Kilzer (:ddkilzer) 2006-12-11 22:30:51 PST
(In reply to comment #6)
> I don't think this is a real regression -- I think I just need to update this
> test result. The point of the test is to check if you crash. 

Layout test results fixed in r18167.