Bug 11786 - Create ResourceHandleBase to eliminate #ifdefs in ResourceHandle and related headers
Summary: Create ResourceHandleBase to eliminate #ifdefs in ResourceHandle and related ...
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 420+
Hardware: PC All
: P3 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-08 12:58 PST by Darin Fisher (:fishd, Google)
Modified: 2011-09-02 16:23 PDT (History)
2 users (show)

See Also:


Attachments
prototype patch for PLATFORM(MAC) only (71.83 KB, patch)
2008-01-24 23:37 PST, Darin Fisher (:fishd, Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2006-12-08 12:58:20 PST
Refactor ResourceHandleInternal to ease porting

Currently it is necessary to #ifdef ResourceHandleInternal when implementing a port of ResourceHandle.  It'd be a lot simpler if ResourceHandlerInternal were a base class that only defined the shared member variables.  Then each port could subclass that to define their port specific member variables, and each port could be responsible for allocating ResourceHandle's d-pointer.

If such a change is acceptable, I'll gladly cut a patch.
Comment 1 Darin Fisher (:fishd, Google) 2008-01-24 23:28:19 PST
I'd like to reframe this bug in terms of creating ResourceHandleBase, which would allow us to eliminate ResourceHandleInternal and avoid a bunch of platform #ifdefs.
Comment 2 Darin Fisher (:fishd, Google) 2008-01-24 23:37:54 PST
Created attachment 18687 [details]
prototype patch for PLATFORM(MAC) only

Here's the initial changes for PLATFORM(MAC).  I'd like feedback on this approach before I make corresponding changes for the other platforms :-)
Comment 3 Darin Fisher (:fishd, Google) 2008-01-25 13:00:00 PST
Comment on attachment 18687 [details]
prototype patch for PLATFORM(MAC) only

actually, this isn't ready for review yet.