RESOLVED FIXED 11777
Crash when using XMLSerializer.serializeToString() on documentless, DocumentType nodes.
https://bugs.webkit.org/show_bug.cgi?id=11777
Summary Crash when using XMLSerializer.serializeToString() on documentless, DocumentT...
Sam Weinig
Reported Thursday, December 7, 2006 8:59:56 PM UTC
If the DocumentType node does not have a Document associated with it, as in cases where you just created one from the DOMImplementation object, webkit crashes reliably. This is a regression from the current shipping Safari.
Attachments
testcase (1.01 KB, text/html)
2006-12-07 14:44 PST, Sam Weinig
no flags
another testcase (1.39 KB, text/html)
2006-12-07 15:11 PST, Sam Weinig
no flags
patch (9.83 KB, patch)
2006-12-07 16:48 PST, Sam Weinig
ggaren: review+
Sam Weinig
Comment 1 Thursday, December 7, 2006 10:44:58 PM UTC
Created attachment 11765 [details] testcase Testcase. This will cause your browser to crash!
Sam Weinig
Comment 2 Thursday, December 7, 2006 11:11:33 PM UTC
Created attachment 11766 [details] another testcase Another testcase that will crash ToT.
Sam Weinig
Comment 3 Friday, December 8, 2006 12:48:52 AM UTC
Geoffrey Garen
Comment 4 Friday, December 8, 2006 7:12:00 AM UTC
Comment on attachment 11767 [details] patch + if (node->nodeType() == Node::DOCUMENT_TYPE_NODE && !node->document()) { It's true that only the DocumentType node can have a NULL document, but I don't see any need to test for the node being a DocumentType node. !node->document() should do. r=me
Sam Weinig
Comment 5 Friday, December 8, 2006 11:58:55 PM UTC
Landed in r18085.
Lucas Forschler
Comment 6 Wednesday, February 6, 2019 5:04:03 PM UTC
Mass moving XML DOM bugs to the "DOM" Component.
Note You need to log in before you can comment on or make changes to this bug.