CLOSED FIXED 11678
[S60] tabbing navigation skips over text content 
https://bugs.webkit.org/show_bug.cgi?id=11678
Summary [S60] tabbing navigation skips over text content
Shaun Keller
Reported 2006-11-22 07:35:05 PST
TSW# TMCN-6TLQ58
Attachments
tabbing navigation fix (15.95 KB, patch)
2006-11-22 07:41 PST, Shaun Keller 		zalan: review-
DetailsFormatted DiffDiff
apply corrections based on Zalan's comments (16.33 KB, patch)
2006-11-27 08:30 PST, Shaun Keller 		zalan: review+
DetailsFormatted DiffDiff
retry at usable diff/patch (14.25 KB, patch)
2006-11-27 09:30 PST, Shaun Keller 		zalan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shaun Keller
Comment 1 2006-11-22 07:41:13 PST
Created attachment 11608 [details] tabbing navigation fix
zalan
Comment 2 2006-11-26 13:41:48 PST
Comment on attachment 11608 [details] tabbing navigation fix in getNewTabbedCursorPosition, you use the same variable name (as the parameter of this function) to call the subframe's getNewTabbedCursorPosition. is it intentional? as with this setup your nodeIndex remains -1 even if it is set to something else in the subframe call. int nodeIndex = -1; bool foundInFrame = foundFrame->getNewTabbedCursorPosition(lr,tb,nodeIndex); in tabbedNavigation, it looks to me that nodeIndex can be easily -1 and that crashes on the following line QRect foundRect = (*_focusableNodeList)[nodeIndex]; and please remove the FIXME comment
Shaun Keller
Comment 3 2006-11-27 08:30:44 PST
Created attachment 11642 [details] apply corrections based on Zalan's comments Thanks for catching the nodeIndex errors. The delta is: removed the creation of shadowing variables; added a test for return nodeIndex value of -1 which now skips over changing the cursor position based on a found node; corrected comments and indenting. I rebuilt, tested and reviewed the changes with Sriram.
Shaun Keller
Comment 4 2006-11-27 09:30:55 PST
Created attachment 11643 [details] retry at usable diff/patch
zalan
Comment 5 2006-11-28 18:27:33 PST
Comment on attachment 11642 [details] apply corrections based on Zalan's comments r=me
zalan
Comment 6 2006-11-28 18:28:01 PST
Comment on attachment 11643 [details] retry at usable diff/patch r=me
zalan
Comment 7 2006-11-28 18:41:14 PST
3.2 17914 3.1m 17915
Krishna
Comment 8 2006-11-30 13:54:56 PST
Verified and Closed.
Note You need to log in before you can comment on or make changes to this bug.