Bug 11658 - KRenderingPaintServer* rework
Summary: KRenderingPaintServer* rework
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-20 13:08 PST by Nikolas Zimmermann
Modified: 2006-11-21 04:33 PST (History)
0 users

See Also:

Attachments
Initial patch (233.91 KB, patch)
2006-11-20 13:44 PST, Nikolas Zimmermann 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2006-11-20 13:08:51 PST 
Similiar to the work in patch 11468 (platform/graphics addition), and 11596 (KCanvasFilters split-up)the KRenderingPaintServer* classes has to be reworked.

The KRenderingPaintServer classes are moved to platform/graphics/svg, named SVGPaintServer*.
Removing the qt/quartz specific KRenderingPaintServer*(Qt/Quartz) which were inherting from
the KRenderingPaintServer* classes and reimplemented functions. Now designed just like all
other code in platform (adding functions, and the implementations in platform specific subdirs).

kcanvas/device/ now only contains KRenderingDevice & KRenderingDeviceContext - to be
integrated within platform/graphics/GraphicsContext soon (Eric already started a patch
some time ago)

Attaching patch soon
Comment 1 Nikolas Zimmermann 2006-11-20 13:44:02 PST 
Created attachment 11589 [details]
Initial patch

No new leaks or regressions introduced.
Comment 2 Oliver Hunt 2006-11-20 18:20:07 PST 
Comment on attachment 11589 [details]
Initial patch

looks fine to me
Comment 3 Nikolas Zimmermann 2006-11-21 04:33:03 PST 
Landed in r17870.
Thanks Oliver for the quick review!