WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
11634
Windows port segfaults on startup
https://bugs.webkit.org/show_bug.cgi?id=11634
Summary
Windows port segfaults on startup
Don Gibson
Reported
2006-11-17 11:28:45 PST
This is due to the FrameLoader not getting a client. The Windows port needs to at least stub one.
Attachments
patch v1
(32.92 KB, patch)
2006-11-17 12:02 PST
,
Don Gibson
sam
: review-
Details
Formatted Diff
Diff
patch v2
(47.08 KB, patch)
2006-11-17 12:55 PST
,
Don Gibson
sam
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Don Gibson
Comment 1
2006-11-17 12:02:04 PST
Created
attachment 11553
[details]
patch v1 This fixes the segfault on startup and a similar segfault when a URL is typed into the address bar, by stubbing EditorClientWin and FrameLoaderClientWin. I don't think clicking on links works; that's probably due to my having stubbed FrameLoaderClientWin instead of implementing it properly.
Sam Weinig
Comment 2
2006-11-17 12:16:21 PST
Comment on
attachment 11553
[details]
patch v1 Despite what I said on IRC, I actually see 3 issues. - FrameLoaderClientWin.h needs a newline at the end. - As long as we are making new files, we might as well follow the guidelines as closely as possible. So, in FrameLoaderClientWin.h please indent all of the class declaration. - Use '0' instead of 'NULL'.
Don Gibson
Comment 3
2006-11-17 12:55:17 PST
Created
attachment 11556
[details]
patch v2 Updated to fix review comments. Also fixes these issues in the code checked in in
r17816
.
Sam Weinig
Comment 4
2006-11-18 12:05:57 PST
Comment on
attachment 11556
[details]
patch v2 Looks good, r+. I would only ask that the committer remove the line with "WARNING: NO TEST CASES ADDED OR CHANGED" on it in the ChangeLog.
Alexey Proskuryakov
Comment 5
2006-11-18 13:09:03 PST
Committed revision 17847.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug