Bug 11593 - Add a way to override WEBCORE_NAVIGATOR_PLATFORM for a specific build
Summary: Add a way to override WEBCORE_NAVIGATOR_PLATFORM for a specific build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 420+
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-13 15:24 PST by Greg Jackson
Modified: 2006-11-14 04:04 PST (History)
0 users

See Also:


Attachments
Adds #ifndef guard for WEBCORE_NAVIGATOR_PLATFORM (1.12 KB, patch)
2006-11-13 16:15 PST, Greg Jackson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Jackson 2006-11-13 15:24:25 PST
I would like to add the ability to define WEBCORE_NAVIGATOR_PLATFORM externally for particular builds.
Comment 1 Greg Jackson 2006-11-13 16:15:10 PST
Created attachment 11512 [details]
Adds #ifndef guard for WEBCORE_NAVIGATOR_PLATFORM
Comment 2 Darin Adler 2006-11-13 16:53:33 PST
That's kinda funny. I was planning to change this to just "PLATFORM" since it's not a global thing, but I suppose this gives a nice way for some platforms to not have to edit this file.
Comment 3 Darin Adler 2006-11-13 16:54:03 PST
Comment on attachment 11512 [details]
Adds #ifndef guard for WEBCORE_NAVIGATOR_PLATFORM

r=me
Comment 4 Mark Rowe (bdash) 2006-11-14 04:04:36 PST
Landed in r17756.