Bug 11571 – Gdk build is out of sync

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Alp Toker]

The gdk port of WebKit appears to have gone out of sync with the rest of the platform. Attached are an update the existing bakefile rules and other related fixes.

Note that these fixes do not yet make it possible to run the launcher test app, but they provide a basis that can continue to be worked upon incrementally.

This should not be considered an alternative to merging the cmake build system, but rather a stop-gap solution that will allow work on the gdk port to continue in the meantime.

[Alp Toker]

Created attachment 11483 [details]
Typo fixes and source file updates to the gdk bakefile

[Alp Toker]

Created attachment 11484 [details]
Only include SVGDocumentExtensions.h when SVG_SUPPORT is defined

[Maciej Stachowiak]

Comment on attachment 11484 [details]
Only include SVGDocumentExtensions.h when SVG_SUPPORT is defined

r=me

[Maciej Stachowiak]

Comment on attachment 11483 [details]
Typo fixes and source file updates to the gdk bakefile

r=me

[Mark Rowe (bdash)]

Created attachment 11489 [details]
Patch

This patch includes the contents of attachment 11483 [details] and attachment 11484 [details], but goes further to allow JSCore and WebCore to compile and link sucessfully.  GdkLauncher does not link against WebCore due to two dozen undefined symbols that are related to the loader and screen refactorings from this week.

[Mark Rowe (bdash)]

Created attachment 11491 [details]
Patch

Remove some commented out lines of code.

Comment on attachment 11491 [details]
Patch

r=me

[Mark Rowe (bdash)]

Landed in r17741.  WebCore should now compile + link correctly, though it will fail with unresolved symbols when being linked into GdkLauncher.  Patches for that should be attached to a new bug report.