Bug 11562 - Fixing build of Qt/KDE platforms
Summary: Fixing build of Qt/KDE platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 420+
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-10 05:09 PST by Zack Rusin
Modified: 2006-11-10 18:47 PST (History)
0 users

See Also:

Attachments
fix the build (61.09 KB, patch)
2006-11-10 05:09 PST, Zack Rusin 		no flags Details | Formatted Diff | Diff
this one makes it compile, link and work (85.11 KB, patch)
2006-11-10 08:33 PST, Zack Rusin 		andersca: review+
Details | Formatted Diff | Diff
fixed capitalization of macro guards (85.12 KB, patch)
2006-11-10 11:10 PST, Zack Rusin 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zack Rusin 2006-11-10 05:09:16 PST 
After the recent changes Qt/KDE code was broken. The attached patch makes it build. Due to not implemented FrameLoaderClient it won't work but at least it builds.
Comment 1 Zack Rusin 2006-11-10 05:09:47 PST 
Created attachment 11459 [details]
fix the build
Comment 2 Zack Rusin 2006-11-10 08:33:34 PST 
Created attachment 11462 [details]
this one makes it compile, link and work

i demand declerations of love for this one
Comment 3 Anders Carlsson 2006-11-10 11:07:38 PST 
Comment on attachment 11462 [details]
this one makes it compile, link and work

r=me assuming you fix the capitalization in the preprocessor directives.
Comment 4 Zack Rusin 2006-11-10 11:10:30 PST 
Created attachment 11463 [details]
fixed capitalization of macro guards
Comment 5 Anders Carlsson 2006-11-10 11:25:08 PST 
Comment on attachment 11463 [details]
fixed capitalization of macro guards

r=me
Comment 6 Mark Rowe (bdash) 2006-11-10 18:47:42 PST 
Landed by Anders in r17703.