Bug 11544 - <legend> rendering doesn't take align into account
Summary: <legend> rendering doesn't take align into account
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 420+
Hardware: Other Linux
: P2 Normal
Assignee: George Staikos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-08 03:59 PST by George Staikos
Modified: 2006-12-04 09:55 PST (History)
0 users

See Also:


Attachments
patch (1.64 KB, patch)
2006-11-08 04:00 PST, George Staikos
hyatt: review-
Details | Formatted Diff | Diff
demonstrate the problem (1.53 KB, text/html)
2006-11-08 04:01 PST, George Staikos
no flags Details
Now with testcase (65.02 KB, patch)
2006-12-03 03:50 PST, Rob Buis
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description George Staikos 2006-11-08 03:59:41 PST
Attached patch fixes alignment rendering for legends and matches FireFox.  Attached html file demonstrates the issue in all cases with both LTR and RTL.  Unfortunately we also exhibit some fieldset rendering problems it seems, but they're unrelated as far as I can tell.
Comment 1 George Staikos 2006-11-08 04:00:51 PST
Created attachment 11422 [details]
patch
Comment 2 George Staikos 2006-11-08 04:01:35 PST
Created attachment 11423 [details]
demonstrate the problem
Comment 3 Dave Hyatt 2006-11-08 04:06:41 PST
Is this behavior true in quirks and strict mode? 
Comment 4 Dave Hyatt 2006-11-08 04:07:10 PST
Comment on attachment 11422 [details]
patch

Please include a layout test.  Thanks.
Comment 5 George Staikos 2006-11-08 07:55:24 PST
I know it needs one but no time to make it right now.  Also didn't check to see if it should happen in strict mode too.
Comment 6 Rob Buis 2006-12-03 03:50:29 PST
Created attachment 11717 [details]
Now with testcase

I noticed no difference in behaviour in quirks and strict mode. The testcase is really just pmax' example.
Cheers,

Rob.
Comment 7 Dave Hyatt 2006-12-04 00:57:59 PST
Comment on attachment 11717 [details]
Now with testcase

r=me
Comment 8 Rob Buis 2006-12-04 01:36:41 PST
Landed in r17995.
Comment 9 David Kilzer (:ddkilzer) 2006-12-04 09:55:23 PST
See also Bug 3280.