11544 – <legend> rendering doesn't take align into account

RESOLVED FIXED 11544

<legend> rendering doesn't take align into account

https://bugs.webkit.org/show_bug.cgi?id=11544

Summary <legend> rendering doesn't take align into account

George Staikos

Reported 2006-11-08 03:59:41 PST

Attached patch fixes alignment rendering for legends and matches FireFox. Attached html file demonstrates the issue in all cases with both LTR and RTL. Unfortunately we also exhibit some fieldset rendering problems it seems, but they're unrelated as far as I can tell.

Attachments
patch (1.64 KB, patch) 2006-11-08 04:00 PST, George Staikos	hyatt: review-	Details Formatted Diff Diff
demonstrate the problem (1.53 KB, text/html) 2006-11-08 04:01 PST, George Staikos	no flags	Details
Now with testcase (65.02 KB, patch) 2006-12-03 03:50 PST, Rob Buis	hyatt: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

George Staikos

Comment 1 2006-11-08 04:00:51 PST

Created attachment 11422 [details] patch

George Staikos

Comment 2 2006-11-08 04:01:35 PST

Created attachment 11423 [details] demonstrate the problem

Dave Hyatt

Comment 3 2006-11-08 04:06:41 PST

Is this behavior true in quirks and strict mode?

Dave Hyatt

Comment 4 2006-11-08 04:07:10 PST

Comment on attachment 11422 [details] patch Please include a layout test. Thanks.

George Staikos

Comment 5 2006-11-08 07:55:24 PST

I know it needs one but no time to make it right now. Also didn't check to see if it should happen in strict mode too.

Rob Buis

Comment 6 2006-12-03 03:50:29 PST

Created attachment 11717 [details] Now with testcase I noticed no difference in behaviour in quirks and strict mode. The testcase is really just pmax' example. Cheers, Rob.

Dave Hyatt

Comment 7 2006-12-04 00:57:59 PST

Comment on attachment 11717 [details] Now with testcase r=me

Rob Buis

Comment 8 2006-12-04 01:36:41 PST

Landed in r17995.

David Kilzer (:ddkilzer)

Comment 9 2006-12-04 09:55:23 PST