Bug 115293 - delete-stale-build-files does not clear .d files
Summary: delete-stale-build-files does not clear .d files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vicki Pfau
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-26 17:16 PDT by Vicki Pfau
Modified: 2013-04-26 17:50 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.29 KB, patch)
2013-04-26 17:18 PDT, Vicki Pfau
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vicki Pfau 2013-04-26 17:16:29 PDT
Empty .d files can be generated sometimes when a build goes bad. We should clean up those files.
Comment 1 Vicki Pfau 2013-04-26 17:18:38 PDT
Created attachment 199878 [details]
Patch
Comment 2 Tim Horton 2013-04-26 17:20:12 PDT
Have you checked to make sure that running this on a good build doesn't cause any extraneous rebuilding on a subsequent build?
Comment 3 Vicki Pfau 2013-04-26 17:47:33 PDT
(In reply to comment #2)
> Have you checked to make sure that running this on a good build doesn't cause any extraneous rebuilding on a subsequent build?

It does not appear to affect build times on a good build at all.
Comment 4 Vicki Pfau 2013-04-26 17:50:21 PDT
Committed r149228: <http://trac.webkit.org/changeset/149228>