WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 11526
REGRESSION(
r17610
): Layout test failure in svg/custom/create-metadata-element.svg
https://bugs.webkit.org/show_bug.cgi?id=11526
Summary
REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element...
Mark Rowe (bdash)
Reported
2006-11-06 03:27:37 PST
The fix for
bug 11524
broke this test as it caused DOMNode::valueOf() to be used when comparing [meta] to a string, rather than DOMNode::toString(). In Firefox DOMNode::valueOf() and DOMNode::toString() return the same value, but we return a string based on nodeName for the former, and className for the latter.
Attachments
Bring consistency to DOMNode::toString/valueOf
(109.19 KB, patch)
2006-11-06 04:56 PST
,
Mark Rowe (bdash)
mjs
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1
2006-11-06 04:56:13 PST
Created
attachment 11396
[details]
Bring consistency to DOMNode::toString/valueOf
Maciej Stachowiak
Comment 2
2006-11-06 04:57:45 PST
Comment on
attachment 11396
[details]
Bring consistency to DOMNode::toString/valueOf r=me
mitz
Comment 3
2006-11-06 05:03:23 PST
+FAILURE: expected "[object META]", actual "[object HTMLMetaElement]" Perhaps the test can adjust its expectations.
Mark Rowe (bdash)
Comment 4
2006-11-06 05:13:01 PST
Landed in
r17615
, fast/dom/HTMLMetaElement/meta-attributes.html results updated in
r17616
. Good catch :)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug