Bug 11504 - Fix warnings on non 32 bit platforms
Summary: Fix warnings on non 32 bit platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 11508
Blocks:
  Show dependency treegraph
 
Reported: 2006-11-03 05:25 PST by Zack Rusin
Modified: 2006-11-03 14:21 PST (History)
1 user (show)

See Also:


Attachments
fix warning by explicitly casting (1.24 KB, patch)
2006-11-03 05:26 PST, Zack Rusin
timothy: review+
Details | Formatted Diff | Diff
alternative fix (4.29 KB, patch)
2006-11-03 09:52 PST, Alexey Proskuryakov
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zack Rusin 2006-11-03 05:25:52 PST
On platforms with 32bit userspace, uintptr_t is 32bits so compiler complains about truncating a 64bit type to 32bits. This is basically the same casts we added in kdelibs to kjs.
Comment 1 Zack Rusin 2006-11-03 05:26:30 PST
Created attachment 11363 [details]
fix warning by explicitly casting
Comment 2 Timothy Hatcher 2006-11-03 09:20:24 PST
Comment on attachment 11363 [details]
fix warning by explicitly casting

Looks fine. static_cast would be safer.
Comment 3 Alexey Proskuryakov 2006-11-03 09:52:10 PST
Created attachment 11364 [details]
alternative fix

This should fix the issue by eliminating runtime checks.
Comment 4 Darin Adler 2006-11-03 12:27:26 PST
Comment on attachment 11364 [details]
alternative fix

I think Alexey's fix is better.

r=me
Comment 5 Alexey Proskuryakov 2006-11-03 14:21:18 PST
Committed revision 17580. Here's hope that my fix actually helps :-)