Bug 11494 – [CSS 3] support for vertical-text, cell and context-menu cursors

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Lars Næsbye Christensen]

Third patch in the project to achieve CSS3 cursor-style support. This adds the vertical-text, cell and context-menu.

[Lars Næsbye Christensen]

Created attachment 11348 [details]
adds support for 3 selectors from CSS 3 cursor style specs

[Sam Weinig]

Comment on attachment 11348 [details]
adds support for 3 selectors from CSS 3 cursor style specs

Looks good but it needs a Changelog and a Layout test.  r- for now.

[Lars Næsbye Christensen]

Adds support for more values in the CSS 3 cursor style property: vertical-text, cell and context-menu.
Third patch towards support of all 32 values.

NB : Apple discourages the use of the 'plus' cursor, but I expect this is the API, not the graphic. A prettier graphic might be added later as part of a unified consistent suite , this is just basic support.

[Lars Næsbye Christensen]

Created attachment 11357 [details]
Patch for 3 more cursor styles from CSS 3 specs

Adds support for more values in the CSS 3 cursor style property: vertical-text,
cell and context-menu. 3rd patch of 5 towards support of all 32 values.

Apple discourages the use of the 'plus' cursor, but I expect this is the
API, not the graphic. A prettier graphic might be added later as part of a
unified consistent suite of cursor images, this is just basic support using a legacy image.

[Timothy Hatcher]

Comment on attachment 11357 [details]
Patch for 3 more cursor styles from CSS 3 specs

Actually this still needs a ChangeLog and a test case.

You can use prepare-ChangeLog to do this.

[Lars Næsbye Christensen]

Created attachment 11384 [details]
Testcase : Shows CSS cursor selectors

[Lars Næsbye Christensen]

Created attachment 11385 [details]
updated to include ChangeLog entry and cleaned up

Hope this does it, then :-P

[Maciej Stachowiak]

Comment on attachment 11385 [details]
updated to include ChangeLog entry and cleaned up

Please fix the email address in the ChangeLog entry. Also it's strongly preferred to include the test case in the patch itself (in WebCore/manual-tests if it's not easily automatable).

[Lars Næsbye Christensen]

Created attachment 11436 [details]
revised - now with edited testcase in manual-tests

OK, now I hope it's allright, then. There was a test case, which I just modified.

Comment on attachment 11436 [details]
revised - now with edited testcase in manual-tests

The ChangeLog entry should include this bug's URL and description. See other ChangeLog entries for example. Also, please add a newline at the end of the test. r- for now because of the ChangeLog.

[Lars Næsbye Christensen]

Created attachment 11481 [details]
yet another revision of the previous patch

fix0r

[Alexey Proskuryakov]

Comment on attachment 11481 [details]
yet another revision of the previous patch

r=me

[Alexey Proskuryakov]

Committed revision 17728.