Bug 11489 - REGRESSION (r13971): Incomplete repaint of flexbox with overflow
Summary: REGRESSION (r13971): Incomplete repaint of flexbox with overflow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2006-11-01 14:19 PST by Adele Peterson
Modified: 2013-07-23 11:31 PDT (History)
3 users (show)

See Also:

Attachments
test case (834 bytes, text/html)
2006-11-01 14:21 PST, Adele Peterson 		no flags Details
Patch v1 (2.54 KB, patch)
2009-06-12 01:03 PDT, Shinichiro Hamaji 		no flags Details | Formatted Diff | Diff
test case modified to be automated (656 bytes, text/html)
2009-06-12 01:12 PDT, Shinichiro Hamaji 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adele Peterson 2006-11-01 14:19:37 PST 
Incomplete repaint of flexbox with overflow

See http://bugs.webkit.org/show_bug.cgi?id=11277 for more discussion.

See attached test case
Comment 1 Adele Peterson 2006-11-01 14:21:09 PST 
Created attachment 11341 [details]
test case
Comment 2 mitz 2007-03-31 08:35:12 PDT 
This seems to be a regression from Safari 2.
Comment 3 David Kilzer (:ddkilzer) 2007-09-02 20:50:16 PDT 
Autospade says:

Works: r13968  Fails: r13972
Comment 4 Shinichiro Hamaji 2009-06-12 01:03:50 PDT 
Created attachment 31195 [details]
Patch v1

 WebCore/ChangeLog                 |   19 +++++++++++++++++++
 WebCore/rendering/RenderBlock.cpp |   10 ++++++++--
 WebCore/rendering/bidi.cpp        |    2 +-
 3 files changed, 28 insertions(+), 3 deletions(-)
Comment 5 Shinichiro Hamaji 2009-06-12 01:09:48 PDT 
This patch depends on the patch I uploaded in https://bugs.webkit.org/show_bug.cgi?id=15135 . So, I don't mark this patch as '?' for now. Once the previous patch is granted, I'll update this patch and ask review.

Regarding the layout test for this patch, I couldn't see how to test this with the layout test framework. The test case Adele posted seems to work correctly with DumpRenderTree (maybe it repaints all area before it generates png file?). I'll upload the layout test I wrote. If someone tell me how to make the layout test fail without this patch, I'll fix and add the layout test for my patch.
Comment 6 Shinichiro Hamaji 2009-06-12 01:12:49 PDT 
Created attachment 31196 [details]
test case modified to be automated
Comment 7 Robert Hogan 2013-07-23 11:31:30 PDT 
The test case works fine now. Please re-open if I'm wrong in thinking that.