Bug 11483 – Fixing rendering on the Qt platform

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Zack Rusin]

I never got to finish GraphicsContext port. The biggest issue was that I didn't want to be updating pen and brush on every operation, which was basically forced by the api. Since GraphicsContext behaves more less exactly like QPainter I'd like to keep both in sync with each other. The patch adds setPlatformPen, setPlatformFillColor and setPlatformFont methods to GraphicsContext. On all platforms but Qt they're empty stubs but on the Qt platform they allow us to keep our painter in sync with the state of GraphicsContext without forcing the (usually expensive) state changes on every rendering operation.
This fixes color and font handling for all rendering (meaning the pages should now actually look correctly).

[Zack Rusin]

Created attachment 11324 [details]
Fixes color/font handling on the Qt platform

[Maciej Stachowiak]

I asked Darin to look at this.

[Dave Hyatt]

It's ok to put #if PLATFORM(QT) in the header around those setPlatformXXX functions.  That way you don't have to change GraphicsContext.cpp.

[Dave Hyatt]

Oh i guess you still have to make the calls.  Never mind.

[Dave Hyatt]

Comment on attachment 11324 [details]
Fixes color/font handling on the Qt platform

Drop the extra space before the closing paren on these three methods in GraphicsContext.cpp:

+void GraphicsContext::setPlatformPen(const Pen& )

+ void GraphicsContext::setPlatformFillColor(const Color& )

+void GraphicsContext::setPlatformFont(const Font& )

r=me

[Zack Rusin]

Created attachment 11346 [details]
cleaned up the patch

[Maciej Stachowiak]

landed