Bug 11483 - Fixing rendering on the Qt platform
Summary: Fixing rendering on the Qt platform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 420+
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-01 05:48 PST by Zack Rusin
Modified: 2006-11-03 02:44 PST (History)
0 users

See Also:


Attachments
Fixes color/font handling on the Qt platform (10.11 KB, patch)
2006-11-01 05:49 PST, Zack Rusin
hyatt: review+
Details | Formatted Diff | Diff
cleaned up the patch (9.65 KB, patch)
2006-11-02 07:33 PST, Zack Rusin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zack Rusin 2006-11-01 05:48:50 PST
I never got to finish GraphicsContext port. The biggest issue was that I didn't want to be updating pen and brush on every operation, which was basically forced by the api. Since GraphicsContext behaves more less exactly like QPainter I'd like to keep both in sync with each other. The patch adds setPlatformPen, setPlatformFillColor and setPlatformFont methods to GraphicsContext. On all platforms but Qt they're empty stubs but on the Qt platform they allow us to keep our painter in sync with the state of GraphicsContext without forcing the (usually expensive) state changes on every rendering operation.
This fixes color and font handling for all rendering (meaning the pages should now actually look correctly).
Comment 1 Zack Rusin 2006-11-01 05:49:35 PST
Created attachment 11324 [details]
Fixes color/font handling on the Qt platform
Comment 2 Maciej Stachowiak 2006-11-01 18:55:05 PST
I asked Darin to look at this.
Comment 3 Dave Hyatt 2006-11-02 00:54:46 PST
It's ok to put #if PLATFORM(QT) in the header around those setPlatformXXX functions.  That way you don't have to change GraphicsContext.cpp.
Comment 4 Dave Hyatt 2006-11-02 00:55:56 PST
Oh i guess you still have to make the calls.  Never mind.
Comment 5 Dave Hyatt 2006-11-02 00:57:47 PST
Comment on attachment 11324 [details]
Fixes color/font handling on the Qt platform

Drop the extra space before the closing paren on these three methods in GraphicsContext.cpp:

+void GraphicsContext::setPlatformPen(const Pen& )

+ void GraphicsContext::setPlatformFillColor(const Color& )

+void GraphicsContext::setPlatformFont(const Font& )

r=me
Comment 6 Zack Rusin 2006-11-02 07:33:09 PST
Created attachment 11346 [details]
cleaned up the patch
Comment 7 Maciej Stachowiak 2006-11-03 02:44:06 PST
landed