As discussed with Darin & Dave, now that platform/graphics exists, a lot of stuff can be moved there from platform/. In detail: AffineTransform Color IntSize IntRect IntPoint Image ImageSource Path Pen FloatSize FloatRect FloatPoint platform/cairo can be moved to platform/graphics/cairo. platform/cg can be moved to platform/graphics/cg. From platform/qt, the respective FooQt.cpp files can be moved into platform/graphics/qt (IntSizeQt, etc..) I'm attaching a script soon which does the svn mv's, and a patch which fixes os x build system & kde/qt.
Created attachment 11304 [details] A script doing the svn mv's automatically This script should ease the committer's life....
Created attachment 11305 [details] Initial patch Just run MoveScript.sh in trunk/. That will move all files correctly, then apply this patch. Compilation tested on osx & Qt platform, ran layout tests/pixel tests/leak tests. Nothing changed.
Created attachment 11309 [details] Updated patch As I found out WebCore.vcproj is indeed hand-editable, I could fix also win32 compilation - of course untested, as I have no win32 dev machine.
Comment on attachment 11309 [details] Updated patch r=me. I'll take care of landing this.
Comment on attachment 11309 [details] Updated patch With a semi-painful patch like this, it makes sense to do as complete a job as possible. Can you move Icon and IntSizeHash into platform/graphics, and move the Mac- and Win-specific implementation files to platform/graphics/mac and platform/graphics/win? Then we won't have to deal with subsequent patches to move those as well. Thanks!
Created attachment 11470 [details] Updated svn move script Also move mac/, win/ subdirectories.
Created attachment 11471 [details] Final version of the move script Forgot to move IconMac.mm before
Created attachment 11472 [details] Updated patch including ChangeLogs
Comment on attachment 11472 [details] Updated patch including ChangeLogs + B27535690B053814002CE64F /* FloatPoint.h in Headers */ = {isa = PBXBuildFile; fileRef = B275353B0B053814002CE64F /* FloatPoint.h */; }; - BC73E3930978CED700EDFF8A /* FloatPoint.h in Headers */ = {isa = PBXBuildFile; fileRef = BC73E3910978CED700EDFF8A /* FloatPoint.h */; settings = {ATTRIBUTES = (Private, ); }; }; On a number of files you're losing the ATTRIBUTES flag. Take a look at WebKitTools/Scripts/do-file-rename for how to rename files correctly. Perhaps you can even use that script here? It's really great that this move is being done!
Created attachment 11485 [details] Updated patch, preserving private attributes in project.pbxproj Incorporated Adam's comments. Tested with fresh build directory, works fine.
Committed revision 17727.