RESOLVED FIXED 11463
Move KCanvasTreeDebug into rendering/ 
https://bugs.webkit.org/show_bug.cgi?id=11463
Summary Move KCanvasTreeDebug into rendering/
Nikolas Zimmermann
Reported 2006-10-30 17:29:31 PST
Move one of the last files in the kcanvas/ subdirectory (KCanvasTreeDebug.cpp) down into rendering/SVGRenderTreeAsText.cpp Uploading patch soon.
Attachments
Initial patch (53.01 KB, patch)
2006-10-31 05:04 PST, Nikolas Zimmermann 		mitz: review-
DetailsFormatted DiffDiff
Updated patch (53.36 KB, patch)
2006-10-31 10:03 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Updated final patch (53.09 KB, patch)
2006-10-31 10:06 PST, Nikolas Zimmermann 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2006-10-31 05:04:49 PST
Created attachment 11295 [details] Initial patch
mitz
Comment 2 2006-10-31 05:21:52 PST
Comment on attachment 11295 [details] Initial patch Please keep #includes sorted (or sort them if you're touching them) and remove the function lists from the ChangeLog. Better yet, rewrite it as: * kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText.cpp
Nikolas Zimmermann
Comment 3 2006-10-31 10:03:46 PST
Created attachment 11301 [details] Updated patch This fixes Mitz's comments.
Nikolas Zimmermann
Comment 4 2006-10-31 10:06:02 PST
Created attachment 11302 [details] Updated final patch Eek, the previous patch had a conflict in the ChangeLog.
Maciej Stachowiak
Comment 5 2006-10-31 10:26:01 PST
Comment on attachment 11302 [details] Updated final patch r=me
Adam Roben (:aroben)
Comment 6 2006-10-31 11:11:39 PST
Landed in r17486
Note You need to log in before you can comment on or make changes to this bug.