RESOLVED FIXED 11461
HitTestResult should be split into HitTestRequest and HitTestResult 
https://bugs.webkit.org/show_bug.cgi?id=11461
Summary HitTestResult should be split into HitTestRequest and HitTestResult
Beth Dakin
Reported 2006-10-30 13:06:36 PST
The boolean member variables of HitTestResult (readonly, active, and mouseMove) are not a part of the RESULT of the hit test. Rather, they are more like conditions for conducting the hit test. So it does not really make sense that they are part of the HitTestResult class.
Attachments
Creates a struct for the request (56.71 KB, patch)
2006-10-30 13:10 PST, Beth Dakin 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2006-10-30 13:10:34 PST
Created attachment 11289 [details] Creates a struct for the request The thing that I dislike about this patch is that it adds a new boolean parameter to all of the nodeAtPoint()s. The only nodeAtPoint() implementation to use any of the fields of HitTestRequst is RenderFrameSet::nodeAtPoint() which asks about readonly. So instead of sending the entire HitTestRequest into all of the nodeAtPoint()s, I just sent the readonly value. I wish I didn't have to do that since no one else needs it, but it doesn't seem like there is another way. Or is there??
Maciej Stachowiak
Comment 2 2006-10-31 11:27:16 PST
Comment on attachment 11289 [details] Creates a struct for the request I'd suggest passing the whole HitTestRequest to the nodeAtPoint methods even though they only need the one bool, just for consistency r=me either way
Beth Dakin
Comment 3 2006-10-31 13:57:35 PST
Committed with r17494.
Note You need to log in before you can comment on or make changes to this bug.