Bug 11437 - use of uninitialized variable
Summary: use of uninitialized variable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: David Carson
URL: http://www.google.com
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-27 11:58 PDT by David Carson
Modified: 2006-10-28 12:07 PDT (History)
0 users

See Also:


Attachments
patch to init value to false (1.04 KB, patch)
2006-10-27 13:36 PDT, David Carson
beidson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Carson 2006-10-27 11:58:23 PDT
In the function SelectionController::setModifyBias(), the case EXTEND: is be hit before m_modifyBiasSet has been initialized. The case funciton looks like this:
case EXTEND:
            if (!m_modifyBiasSet) {
                m_modifyBiasSet = true;
....

It is being hit when the user first starts to type something into the search box on www.google.com.
Not sure what the value should be initialized to.
Comment 1 David Carson 2006-10-27 13:27:44 PDT
From the looks of the code, it seems as if the value should be initialized to false.
Comment 2 David Carson 2006-10-27 13:36:02 PDT
Created attachment 11259 [details]
patch to init value to false
Comment 3 Brady Eidson 2006-10-27 13:55:40 PDT
Comment on attachment 11259 [details]
patch to init value to false

r=me
Comment 4 Sam Weinig 2006-10-28 12:07:41 PDT
Landed in r17400.