Bug 11436 – KCanvas rework - Part I

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Nikolas Zimmermann]

There is no need for KCanvas in WebKit anymore. As long-term
solution it has to die, and the needed functionality should be merged
into platform/ code.

In this first patch chunk, I'll concentrate on moving resources from kcanvas/
into a new directory platform/graphics. Resources previously living in kcanvas/device/quartz
are moved to platform/graphics/quartz (same for the Qt device).

I tried to keep source-code differences low. For instance you'll notice the
virtual createResource() function in the KRenderingDevice (Qt/Quartz) is not
needed anymore, as in platform/graphics we don't have the class hierarchy
"KCanvasMaskerQuartz inherits from KCanvasMasker" anymore, but instead
have one single GraphicsResourceMasker file, which just leaves out implementations
of certain functions (ie. applyMask()) and leaves that to the platform specific code.
So this concept is identical to the rest of platform/ now.

In an upcoming patch, these creation stuff will be cleaned up:
- remove createResource() from KRenderingDevice, and just create the instances
   of the needed objects directly in the SVG* classes
- adapt the last resource(s): KCanvasFilter to the new concept
   - split the dozen of classes up into pieces (the general one-file-by-class rule)

The real aim is to kill KRenderingDevice/KRenderingDeviceContext and integrate
within GraphicsContext - that will make SVG much more "integrated" into WebKit.

Uploading patches soon, as it's quite large I'll split up into some parts. I am aware
the general rule is to split up large patches into several seperated bug reports, though
these chunks aren't meant to be commited so far. Once they are discussed/reviewed
I'll create a final patch concating all the chunk patches, including ChangeLogs, which
can be commited in one-shot. I hope this way is acceptable.

Cheers, Niko

[Nikolas Zimmermann]

Created attachment 11245 [details]
Chunk #1: kcanvas-changes.diff, Initial patch

[Nikolas Zimmermann]

Created attachment 11246 [details]
Chunk #2: kcanvas-qt-changes.diff, Initial patch

[Nikolas Zimmermann]

Created attachment 11247 [details]
Chunk #3: kcanvas-quartz-changes.diff, Initial patch

[Nikolas Zimmermann]

Created attachment 11248 [details]
Chunk #4: platform-changes.diff, Initial patch

[Nikolas Zimmermann]

Created attachment 11249 [details]
Chunk #5: platform-qt-changes.diff, Initial patch

[Nikolas Zimmermann]

Created attachment 11250 [details]
Chunk #6: platform-quartz-changes.diff, Initial patch

[Nikolas Zimmermann]

Created attachment 11251 [details]
Chunk #7: ksvg-changes.diff, Initial patch

[Nikolas Zimmermann]

Created attachment 11252 [details]
Chunk #8: rendering-changes.diff, Initial patch

[Nikolas Zimmermann]

Created attachment 11253 [details]
Chunk #9: build-system-changes.diff, Initial patch

[Nikolas Zimmermann]

Sorry for the patch flood, though I used a consisten naming scheme:
Chunk #N - patch-name.diff, Initial Patch

any new chunk will be named "Updated patch I" / "Updated patch II" etc.. :-)
In case new patches are needed :-)

Thanks a lot for looking into this.
Niko

[Nikolas Zimmermann]

Created attachment 11277 [details]
Final patch including ChangeLogs

No LayoutTests broken. No new leaks introduced.

[Adam Roben (:aroben)]

Comment on attachment 11253 [details]
Chunk #9: build-system-changes.diff, Initial patch

If we're moving things out of platform and into graphics, we need to do it for all platforms. I'd also want Darin and/or Maciej to take a look at it before this gets landed.

[Nikolas Zimmermann]

Created attachment 11291 [details]
Updated final patch

Incorporated Darin's comments from private mail exchange.
Location and file names changed.

[Nikolas Zimmermann]

Landed by Oliver in r17647.