RESOLVED FIXED 11413
REGRESSION (r17280): Assertion failure in -[WebHTMLView(WebInternal) _delegateDragSourceActionMask] (_private->mouseDownEvent != nil) when clicking selected text 
https://bugs.webkit.org/show_bug.cgi?id=11413
Summary REGRESSION (r17280): Assertion failure in -[WebHTMLView(WebInternal) _delegat...
mitz
Reported 2006-10-25 05:59:38 PDT
Backtrace: 0 com.apple.WebKit 0x01070258 -[WebHTMLView(WebInternal) _delegateDragSourceActionMask] + 96 (WebHTMLView.m:4999) 1 com.apple.WebKit 0x0103c904 -[WebFrameBridge allowDHTMLDrag:UADrag:] + 292 (WebFrameBridge.mm:966) 2 com.apple.WebCore 0x021b36a4 WebCore::FrameMac::eventMayStartDrag(NSEvent*) const + 212 (FrameMac.mm:1569) 3 com.apple.WebKit 0x01064c30 -[WebHTMLView shouldDelayWindowOrderingForEvent:] + 348 (WebHTMLView.m:2846) 4 com.apple.AppKit 0x93766d08 -[NSWindow sendEvent:] + 1664 5 com.apple.Safari 0x00021734 0x1000 + 132916 6 com.apple.AppKit 0x937108d4 -[NSApplication sendEvent:] + 4172 7 com.apple.Safari 0x00021238 0x1000 + 131640 8 com.apple.AppKit 0x93707d10 -[NSApplication run] + 508 9 com.apple.AppKit 0x937f887c NSApplicationMain + 452 10 com.apple.Safari 0x0005c77c 0x1000 + 374652 11 com.apple.Safari 0x0005c624 0x1000 + 374308 The direct cause is probably this change to shouldDelayWindowOrderingForEvent: in r17280: WebHTMLView *hitHTMLView = [hitView isKindOfClass:[self class]] ? (WebHTMLView *)hitView : nil; if (hitHTMLView != nil) { - [hitHTMLView _setMouseDownEvent:event]; - BOOL result = [hitHTMLView _isSelectionEvent:event] ? [[hitHTMLView _bridge] eventMayStartDrag:event] : NO; + bool result = false; + if ([hitHTMLView _isSelectionEvent:event]) + if (FrameMac* frame = [[hitHTMLView _bridge] _frame]) + result = frame->eventMayStartDrag(event); [hitHTMLView _setMouseDownEvent:nil]; return result;
Attachments
Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2006-10-25 10:20:35 PDT
We have to add back the missing call to _setMouseDownEvent!
mitz
Comment 2 2006-10-27 08:11:48 PDT
Fixed by Darin in r17299!
Darin Adler
Comment 3 2006-10-27 11:13:38 PDT
Oops, yes, I forgot to mention that. I should really have figured out how to make a layout test for this.
Note You need to log in before you can comment on or make changes to this bug.