Bug 11411 - REGRESSION (r17280): Repro crash when clicking a link with target="_blank"
Summary: REGRESSION (r17280): Repro crash when clicking a link with target="_blank"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Critical
Assignee: Nobody
URL:
Keywords: EasyFix, Regression
Depends on:
Blocks:
 
Reported: 2006-10-25 02:16 PDT by mitz
Modified: 2006-10-25 05:19 PDT (History)
0 users

See Also:

Attachments
Fix (1.33 KB, patch)
2006-10-25 04:24 PDT, David Smith 		no flags Details | Formatted Diff | Diff
Updated based on comments (1.29 KB, patch)
2006-10-25 04:40 PDT, David Smith 		no flags Details | Formatted Diff | Diff
Once more into the breach... (1.29 KB, patch)
2006-10-25 04:46 PDT, David Smith 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2006-10-25 02:16:12 PDT 
Safari crashes when you click a link with target="_blank" in a document with an http: URL. The crash is in -[WebCoreFrameBridge canTargetLoadInFrame:] due to this change in r17280:

-    WebCoreFrameBridge *parentBridge = [targetFrame parent];
+    WebCoreFrameBridge *parentBridge = Mac([targetFrame _frame]->tree()->parent())->bridge();
Comment 1 David Smith 2006-10-25 04:24:45 PDT 
Created attachment 11201 [details]
Fix
Comment 2 David Smith 2006-10-25 04:40:20 PDT 
Created attachment 11204 [details]
Updated based on comments
Comment 3 David Smith 2006-10-25 04:46:52 PDT 
Created attachment 11205 [details]
Once more into the breach...

Silly *s, always being in the wrong place.
Comment 4 mitz 2006-10-25 04:49:08 PDT 
Comment on attachment 11205 [details]
Once more into the breach...

r=me
Comment 5 Mark Rowe (bdash) 2006-10-25 05:19:10 PDT 
Landed in r17288.