Bug 11407 - [S60] Plugin scripting not working
Summary: [S60] Plugin scripting not working
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 312.x
Hardware: S60 Hardware S60 3rd edition
: P2 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-24 16:28 PDT by Sriram
Modified: 2006-11-11 21:14 PST (History)
0 users

See Also:

Attachments
Scriptable plugin and widget API implementation (541.95 KB, patch)
2006-10-24 16:39 PDT, Sriram 		no flags Details | Formatted Diff | Diff
Added change for widget identifier (535.35 KB, patch)
2006-10-25 11:47 PDT, Sriram 		zalan: review+
Details | Formatted Diff | Diff
Remove FileTransaction changes to previous patch (541.74 KB, patch)
2006-10-25 14:07 PDT, Sriram 		no flags Details | Formatted Diff | Diff
Remove File Transaction and use void* for passing js objects (542.43 KB, patch)
2006-10-25 14:18 PDT, Sriram 		no flags Details | Formatted Diff | Diff
Fix SDK build break (542.64 KB, patch)
2006-10-25 14:55 PDT, Sriram 		no flags Details | Formatted Diff | Diff
Fix SDK build break (392.53 KB, patch)
2006-10-25 15:38 PDT, Sriram 		no flags Details | Formatted Diff | Diff
Fix build break in SDK (541.83 KB, patch)
2006-10-25 17:59 PDT, Sriram 		Sachin.Padma: review+
Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sriram 2006-10-24 16:28:05 PDT 
Scriptable plugin is not working
Comment 1 Sriram 2006-10-24 16:39:40 PDT 
Created attachment 11197 [details]
Scriptable plugin and widget API implementation
Comment 2 zalan 2006-10-24 17:44:01 PDT 
i'm not sure what the policy is on exporting files to epoc32\include\oem. please check that first.
Comment 3 Sriram 2006-10-25 07:23:14 PDT 
(In reply to comment #2)
> i'm not sure what the policy is on exporting files to epoc32\include\oem.
> please check that first.
> 

Exports in the new set up need to be handled as follows:
// Export Browser Control headers
..\BrowserControl\inc\BrCtlDefs.h            MW_LAYER_DOMAIN_EXPORT_PATH(BrCtlDefs.h)

This shouldnt be done for SDK build
Comment 4 Sriram 2006-10-25 11:47:35 PDT 
Created attachment 11210 [details]
Added change for widget identifier
Comment 5 zalan 2006-10-25 12:55:37 PDT 
Comment on attachment 11210 [details]
Added change for widget identifier

r=me
Comment 6 Sachin Padma 2006-10-25 13:20:19 PDT 
Comment on attachment 11210 [details]
Added change for widget identifier

Webkit changes not ok. IMPORT_C and EXPORT_C missing from the brctl.h and cpp files. FileTransaction changes should not be checked in. Please use void* in webkit for KJS::ObjectImp*
Comment 7 Sriram 2006-10-25 14:07:39 PDT 
Created attachment 11211 [details]
Remove FileTransaction changes to previous patch
Comment 8 Sriram 2006-10-25 14:18:54 PDT 
Created attachment 11212 [details]
Remove File Transaction and use void* for passing js objects
Comment 9 Sriram 2006-10-25 14:55:45 PDT 
Created attachment 11213 [details]
Fix SDK build break
Comment 10 Sriram 2006-10-25 15:38:47 PDT 
Created attachment 11215 [details]
Fix SDK build break
Comment 11 Sriram 2006-10-25 17:59:27 PDT 
Created attachment 11218 [details]
Fix build break in SDK

If buikd breaks, remove "\ No newline at end of file" for utility & algorithm files located in X:\s60\JavaScriptCore\bindings
Comment 12 Sachin Padma 2006-10-26 06:29:37 PDT 
Comment on attachment 11218 [details]
Fix build break in SDK

r=me
Comment 13 Sachin Padma 2006-10-26 06:34:50 PDT 
committed r17301