Bug 11406 - Crash in WebCore::FrameLoader::documentLoader()
Summary: Crash in WebCore::FrameLoader::documentLoader()
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Major
Assignee: Brady Eidson
URL: http://www.cbc.ca/world/story/2006/10...
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-24 12:53 PDT by Matt Lilek
Modified: 2006-10-24 18:16 PDT (History)
1 user (show)

See Also:


Attachments
crashlog (20.00 KB, text/plain)
2006-10-24 12:54 PDT, Matt Lilek
no flags Details
Patch to fix (2.14 KB, patch)
2006-10-24 14:27 PDT, Brady Eidson
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lilek 2006-10-24 12:53:22 PDT
Going to the URL above causes the latest nightlies to crash.  Regressed between the r17233 and r17241 builds.  This isn't specific to that page, but happens on any individual story on cbc.ca.
Comment 1 Matt Lilek 2006-10-24 12:54:12 PDT
Created attachment 11194 [details]
crashlog
Comment 2 Mark Rowe (bdash) 2006-10-24 13:12:42 PDT
I'm also seeing this on various different sites.  
Comment 3 Brady Eidson 2006-10-24 14:19:24 PDT
In our quest to transition from ObjC to ObjC++ we're losing alot of the free "null checking" that messaging nil provided.  This is one of those cases.  I'll have a patch very soon
Comment 4 Brady Eidson 2006-10-24 14:27:03 PDT
Created attachment 11195 [details]
Patch to fix

Do come null check that is required now, whereas it was "free nil checking" in ObjC before
Comment 5 Anders Carlsson 2006-10-24 14:29:22 PDT
Comment on attachment 11195 [details]
Patch to fix

r=me
Comment 6 Brady Eidson 2006-10-24 14:31:35 PDT
Commited in r17261