Bug 11367 – Inline Breakpoint Editor Improvements: Act III

• Status: CLOSED
• Resolution: FIXED
• Component: New Bugs

[David Smith]

Stuff the attached patch does:

        • Breakpoints can now either pause or log to console
        • Code cleanup through use of XPath and converting breakpoints to objects
        • Breakpoints now track how many times they've been reached
        • UI tweaks
        • The breakpoint editor now saves changes as they're entered
        • Because changes are auto-saved now, the save button has been converted to a close button (images from PSMTabBarControl, BSD licensed)
        • If an expression with no return is entered as a condition, it will be wrapped transparently with a return statement.

[David Smith]

Created attachment 11162 [details]
See bug description

[David Smith]

The URL is a screenshot of the updated editor

[Timothy Hatcher]

Comment on attachment 11162 [details]
See bug description

Looks good.

Some comments:

Make the bullets in the ChangeLog asterisks.

Remove the white background and border on the .hitCounter.

Make sure you didn't break the console history now that we can log msgs without expressions. IIRC the history relied on childNode indices.

+    while(!node.hasStyleClass(className))
+    {

Our style puts the { on the same line as while.

+        if(node == document) return null;

Our style puts the "return null;" on the next line. Also a space after the if.

The same same firstParentWithClass code in viewer.html.

new Function("toggleBreakpointEditorOnLine(parseInt(event.target.title));")

This can be written as:

function () { toggleBreakpointEditorOnLine(parseInt(event.target.title)); }

+    if(breakpoint && breakpoint.enabled) {
+                if(shouldBreak)
+                if(breakpoint.value != "break")
+                if(consoleWindow)
+        if(editor)
+        if(counter)

Add a space after the if.

[Timothy Hatcher]

Add the bug title and URL to the ChangeLog also.

[Timothy Hatcher]

I don;t think the parseInt() is needed also. JavaScript will convert to int or string as needed.

[David Smith]

Created attachment 11168 [details]
Updated based on comments

[Timothy Hatcher]

Landed in r17184.

[Timothy Hatcher]

Closing since Drosera has been replaced by the new Web Inspector debugger. Moving to the New Bugs component so the Drosera component can be closed and removed.