Bug 11348 - [S60] File transaction should handle the case of escaped file schemed url
Summary: [S60] File transaction should handle the case of escaped file schemed url
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 420+
Hardware: S60 Hardware S60 3rd edition
: P3 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-18 10:37 PDT by Wei Liu
Modified: 2006-11-11 21:19 PST (History)
0 users

See Also:

Attachments
file transaction fix for escaped file url (8.88 KB, patch)
2006-10-18 10:51 PDT, Wei Liu 		Sachin.Padma: review-
Details | Formatted Diff | Diff
Files: BrCtl.cpp, FileTransaction.cpp (6.33 KB, patch)
2006-10-27 13:29 PDT, Joseph Ligman 		Sachin.Padma: review-
Details | Formatted Diff | Diff
Files: BrCtl.cpp, FileTransaction.cpp (6.34 KB, patch)
2006-10-30 11:32 PST, Joseph Ligman 		joseph.ligman: review-
Details | Formatted Diff | Diff
Files: FileTransaction.cpp (1.69 KB, patch)
2006-11-01 10:53 PST, Joseph Ligman 		Sachin.Padma: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wei Liu 2006-10-18 10:37:44 PDT 
File transaction should handle the case of escaped file schemed url
Comment 1 Wei Liu 2006-10-18 10:51:08 PDT 
Created attachment 11136 [details]
file transaction fix for escaped file url
Comment 2 Sachin Padma 2006-10-20 12:50:40 PDT 
Comment on attachment 11136 [details]
file transaction fix for escaped file url

The escaping should be generic.
Comment 3 Joseph Ligman 2006-10-27 13:29:45 PDT 
Created attachment 11258 [details]
Files: BrCtl.cpp, FileTransaction.cpp

This patch uses the TUriParser::GetFileNameL(EUriFileNameFull) to generate the file path.
Comment 4 Joseph Ligman 2006-10-30 11:32:40 PST 
Created attachment 11287 [details]
Files: BrCtl.cpp, FileTransaction.cpp

Added a TRAP_IGNORE around TUriParser::GetFileNameL since invalid paths should return NULL and are not expected to leave.
Comment 5 Joseph Ligman 2006-11-01 10:53:54 PST 
Created attachment 11330 [details]
Files: FileTransaction.cpp

Remove any escaped characters in the file path with EscapeUtils::EscapeDecodeL.
Comment 6 Sachin Padma 2006-11-03 10:19:57 PST 
Comment on attachment 11330 [details]
Files: FileTransaction.cpp

r=me
Comment 7 Sachin Padma 2006-11-03 11:10:11 PST 
committed as r17576