The new listbox control (landed in r16718) broke fast/forms/display-none-in-onchange-keyboard
Looking at the test page and tabbing among the controls manually, it seems that the "two" item in the second <select> doesn't get focused. Perhaps this is the problem?
I was clearly too tired when filing these bugs. The test broken by this change is actually fast/forms/focus-control-to-page
To be clear, r16718 (new RenderListBox) broke fast/forms/focus-control-to-page.
I rolled out the list box change, and the test still fails
I'll take this one.
Nightlies confirm that this regression happened from r16710 to 16729.
Surprisingly, rolling out 16718 and 16719 doesn't fix the bug.
Narrowed down to 16710:16720.
Narrowed down to 16714:16717.
Narrowed down to 16715:16717, which by the way is impossible, so... ?
Did you narrow this down by rolling out changes, or actually going back to those revisions and testing?
Some of each. New data: r16718 has the regression. Rolling back to r16717 fixes the regression. However, Rolling r16718 out of TOT does not fix the regression.
Created attachment 11169 [details] fix Beth reviewed this.