Bug 11314 - Fix build when XSLT_SUPPORT is not defined
Summary: Fix build when XSLT_SUPPORT is not defined
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: PC OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-16 07:24 PDT by Krzysztof Kowalczyk
Modified: 2006-10-24 06:20 PDT (History)
0 users

See Also:

Attachments
fix build when XSLT_SUPPORT is not defined (1.53 KB, patch)
2006-10-16 07:26 PDT, Krzysztof Kowalczyk 		aroben: review-
Details | Formatted Diff | Diff
fix unconditional use of XSLT (1.23 KB, patch)
2006-10-17 06:24 PDT, Krzysztof Kowalczyk 		timothy: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Kowalczyk 2006-10-16 07:24:27 PDT 
Currently XSLT_SUPPORT is forced by WebCore\config.h, which defeats the purpose of having it configurable (should be passed from a Makefile) and one place unconditionally uses xslt support.
Comment 1 Krzysztof Kowalczyk 2006-10-16 07:26:27 PDT 
Created attachment 11110 [details]
fix build when XSLT_SUPPORT is not defined

* remove #define XSLT_SUPPORT from WebCore\config.h, because it defeats the purpose of having it configurable (should be passed from a Makefile)
* fix on place in XMLTokenizer that was using xslt support unconditionally
Comment 2 Adam Roben (:aroben) 2006-10-16 14:17:35 PDT 
Comment on attachment 11110 [details]
fix build when XSLT_SUPPORT is not defined

If you're going to make this change to config.h, you'll need to change the build configurations on Mac (at least).
Comment 3 Krzysztof Kowalczyk 2006-10-16 14:24:43 PDT 
I can't do it since I have no access to Mac. I was hoping that a mac-owning commiter could do it.
Comment 4 Krzysztof Kowalczyk 2006-10-17 06:24:50 PDT 
Created attachment 11123 [details]
fix unconditional use of XSLT

Updated the patch to not modify config.h. I would still like this change to be made but if submitting a change to xcode project files is a requirement for the patch, then unfortunately I can't do it because I don't have access to mac/xcode. For someone having an apple, it should be trivial.
Comment 5 Sam Weinig 2006-10-24 06:20:57 PDT 
Landed in r17252.