Bug 11300 – [Drosera] Inline breakpoint editor

• Status: CLOSED
• Resolution: FIXED
• Component: New Bugs

[David Smith]

Xcode 3 has an inline breakpoint editor that, while less than ideal, provides some interesting ideas for interaction. Attached is a draft patch to add this functionality to Drosera.

[David Smith]

Created attachment 11094 [details]
Draft patch to add an Xcode 3 style inline breakpoint editor

Just an added comment to the bug... I believe this Xcode 3 thing is safe to talk about, since it's on the Apple leopard page. If I'm breaking my NDA here, please tell me to shut up rather than cease-and-desisting. ;)

[David Smith]

One further comment: the lack of transparent background on the images is a known issue with the current patch; I'll be re-photoshopping them before I ask for review.

[David Smith]

Created attachment 11131 [details]
Updated patch

Fixes the transparency issues, and some state consistency issues.

[Timothy Hatcher]

Comment on attachment 11131 [details]
Updated patch

Looks good.

[Timothy Hatcher]

Three issues I fixed before landing.

I tweaked the margins of the editor to have less space.

Also the onlick in the editor html needs to reference window.parent to work. I made that change.
onclick="window.parent.toggleBreakpointForEditor(this.parentNode.parentNode.parentNode)

I made the save button remove the editor.

Landed in r17107.

[Timothy Hatcher]

Also when creating the editor div you need to create it in the source document, not the parent document. The source is in an iframe. Since that is the document you will apend to you need to create it there also. I made that change.

[Timothy Hatcher]

Closing since Drosera has been replaced by the new Web Inspector debugger. Moving to the New Bugs component so the Drosera component can be closed and removed.