Bug 11294 - Add getModifierState method to KeyboardEvent
Summary: Add getModifierState method to KeyboardEvent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-14 14:04 PDT by Sam Weinig
Modified: 2006-10-15 15:29 PDT (History)
0 users

See Also:

Attachments
patch (4.58 KB, patch)
2006-10-14 15:34 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
patch 2 (4.54 KB, patch)
2006-10-15 14:25 PDT, Sam Weinig 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2006-10-14 14:04:04 PDT 
The DOM3 events spec (http://www.w3.org/TR/2003/NOTE-DOM-Level-3-Events-20031107/events.html#Events-KeyboardEvent) includes a getModifierState method that currently we only implement in the Objective-C bindings.  We should implement in KeyboardEvent instead so that it can be used for all the bindings.
Comment 1 Sam Weinig 2006-10-14 15:34:09 PDT 
Created attachment 11090 [details]
patch

Moves functionality down from Objective-C DOM file DOMEvents.mm to KeyboardEvent class.
Comment 2 Sam Weinig 2006-10-15 14:25:40 PDT 
Created attachment 11100 [details]
patch 2

Updated based on conversation with mitz in IRC.
Comment 3 mitz 2006-10-15 14:29:07 PDT 
Comment on attachment 11100 [details]
patch 2

r=me
Comment 4 Sam Weinig 2006-10-15 15:29:01 PDT 
Landed in r17064.