Bug 11266 - [S60] Both RnD and SDK icons are being used
Summary: [S60] Both RnD and SDK icons are being used
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 420+
Hardware: S60 Emulator S60 3rd edition
: P2 Normal
Assignee: Bradley Morrison
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-12 10:57 PDT by Bradley Morrison
Modified: 2006-10-27 18:20 PDT (History)
1 user (show)

See Also:

Attachments
icons.mk queries envionment to determine which icons to create (3.50 KB, patch)
2006-10-12 11:29 PDT, Bradley Morrison 		zalan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bradley Morrison 2006-10-12 10:57:37 PDT 
Recent changes to WebKit\group\icons.mk are incorrect as icons are being created/checked for both RnD and SDK locations. Only one or the other should be created. Depending on the style of compilation.
Comment 1 Bradley Morrison 2006-10-12 11:01:32 PDT 
The cleanest way to do this is to set an environment variable in the build script, and change icon.mk to generate/check the relevant type of icons depending on the value of that environment variable.

I dumped the environment variable that the makefile has and while I could probably key it off something that already exists, it would probably be obscure and more difficult to maintain (like version numbers in MWCSym2Includes, for example).

Therefore I think new environment variable BROWSER_SDK should be set. Surprising this has not been required before.
Comment 2 Bradley Morrison 2006-10-12 11:29:32 PDT 
Created attachment 11049 [details]
icons.mk queries envionment to determine which icons to create
Comment 3 zalan 2006-10-12 11:43:53 PDT 
Comment on attachment 11049 [details]
icons.mk queries envionment to determine which icons to create

r=me
Comment 4 Bradley Morrison 2006-10-12 11:51:40 PDT 
(In reply to comment #3)
> (From update of attachment 11049 [details] [edit])
> r=me
> 

Thanks - applied r17012
Comment 5 Krishna 2006-10-16 10:50:18 PDT 
TSW ID: KPOY-6UMLFN
Comment 6 Krishna 2006-10-27 18:20:04 PDT 
S60WebKitTrunkSDK\20061027161039

Also Closed.