Bug 11250 – File upload form control isn't finished on Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Brett Wilson (Google)]

It appears there is a Browse button that doesn't do anything and no text field currently.

[Brett Wilson (Google)]

Created attachment 11053 [details]
Patch to make it work

This patch separates out the file upload controls from TemporaryLinkStubs into a new file. It implements the basic functionality necessary to open the standard Windows open file dialog and to set the filename back into the control.

Unimplemented is fancy splitting of the filename, so it will just get cut off if the control isn't wide enough.

This also has a spacing change to the vcproj for WebCore. Visual Studio will "fix" this every time somebody changes the file, so we should fix it to prevent everybody from having to manually factor it out of their diff.

[Sam Weinig]

Comment on attachment 11053 [details]
Patch to make it work

I'm r-  this due to a couple of style issues I see.

Please put the curly brace on the same line as the namespace declaration.

+namespace WebCore
+{

The curly brace for functions should go on it's own line and the content should be indented 4 spaces.  I'm also not sure the commented is need.

+// static
+PassRefPtr<FileChooser> FileChooser::create(Document* doc, RenderFileUploadControl* control) {
+  return new FileChooser(doc, control);
+}

Otherwise, it's looking good.