Bug 11248 - Even More auto-generated Objective-C DOM bindings changes
Summary: Even More auto-generated Objective-C DOM bindings changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-10 15:38 PDT by Sam Weinig
Modified: 2006-10-10 20:52 PDT (History)
1 user (show)

See Also:

Attachments
patch (66.96 KB, patch)
2006-10-10 15:46 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
patch 2 (67.27 KB, patch)
2006-10-10 18:25 PDT, Sam Weinig 		timothy: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2006-10-10 15:38:18 PDT 
Patch forthcoming.
Comment 1 Sam Weinig 2006-10-10 15:46:55 PDT 
Created attachment 11025 [details]
patch

- Auto-generate DOMSVGPathElement. (I think this is the final SVG class to generate!!)

- Auto-generate the internal interfaces even for classes that have custom internal implementations.  Change IDL property from ObjCNoInternal to ObjCCustomInternalImpl to indicate the change.

- Add SVG classes to DOMNode and DOMEvent internal interfaces.

- Add isSVGZoomEvent() method to Event class to match other Event subclasses and make DOM binding possible.

- Assorted cleanups.
Comment 2 Sam Weinig 2006-10-10 15:49:36 PDT 
As noted in a FIXME in the patch, I use two HashMaps to differentiate between HTML and SVG classes in DOM.mm.  I did not try to make to a HashMap that mapped from QualifiedNames to Classes, as I've had some issues getting HashMaps to work in the last couple days, but, it this is easy, I think it would be a better solution.
Comment 3 Sam Weinig 2006-10-10 18:25:07 PDT 
Created attachment 11027 [details]
patch 2

Scratch that last comment.  The patch now uses one HashMap that maps from a QualifedName to a Class.
Comment 4 Sam Weinig 2006-10-10 20:52:27 PDT 
Landed in r16982.