Bug 11226 - linux/gdk build fixes; fix memleaks; gdk improvements
Summary: linux/gdk build fixes; fix memleaks; gdk improvements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-09 05:54 PDT by Krzysztof Kowalczyk
Modified: 2006-10-09 16:13 PDT (History)
0 users

See Also:


Attachments
linux/gdk build fixes; minor gdk improvements (12.68 KB, patch)
2006-10-09 06:02 PDT, Krzysztof Kowalczyk
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Kowalczyk 2006-10-09 05:54:14 PDT
Fix linux/gdk build and minor gdk improvements.
Comment 1 Krzysztof Kowalczyk 2006-10-09 06:02:11 PDT
Created attachment 10991 [details]
linux/gdk build fixes; minor gdk improvements

Fix gdk build by adding missing PlatformScrollbar functions.

Improve gdk by:
* change compiler options to not use rtti and exceptions, which is the same thing that mac build is doing and results in significant savings in the size of stripped executable
* set warning to default (from off) and make sure debug info is generated.
* mark ~FrameGdk() as virtual, as it should be
* define SOURCE_ROOT in make-generated-sources.sh since it's used by one of the code generation scripts and without it make-generated-sources.sh fail for gdk build
* cleanup GdkLauncher\main.cpp formatting and add -exit-after-loading command-line option which causes the app to exit after fully loading and rendering a page. It's very useful for e.g. running automated memory leaks and profiling tests with valgrind
* fix 2 memory leaks (ImageCairo.cpp and FrameGkd.cpp) found by running valgrind
Comment 2 Geoffrey Garen 2006-10-09 16:04:02 PDT
Comment on attachment 10991 [details]
linux/gdk build fixes; minor gdk improvements

r=me
Comment 3 Mark Rowe (bdash) 2006-10-09 16:13:59 PDT
Landed in r16945.  Thanks Krzysztof!