RESOLVED FIXED 11226
linux/gdk build fixes; fix memleaks; gdk improvements 
https://bugs.webkit.org/show_bug.cgi?id=11226
Summary linux/gdk build fixes; fix memleaks; gdk improvements
Krzysztof Kowalczyk
Reported 2006-10-09 05:54:14 PDT
Fix linux/gdk build and minor gdk improvements.
Attachments
linux/gdk build fixes; minor gdk improvements (12.68 KB, patch)
2006-10-09 06:02 PDT, Krzysztof Kowalczyk 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Krzysztof Kowalczyk
Comment 1 2006-10-09 06:02:11 PDT
Created attachment 10991 [details] linux/gdk build fixes; minor gdk improvements Fix gdk build by adding missing PlatformScrollbar functions. Improve gdk by: * change compiler options to not use rtti and exceptions, which is the same thing that mac build is doing and results in significant savings in the size of stripped executable * set warning to default (from off) and make sure debug info is generated. * mark ~FrameGdk() as virtual, as it should be * define SOURCE_ROOT in make-generated-sources.sh since it's used by one of the code generation scripts and without it make-generated-sources.sh fail for gdk build * cleanup GdkLauncher\main.cpp formatting and add -exit-after-loading command-line option which causes the app to exit after fully loading and rendering a page. It's very useful for e.g. running automated memory leaks and profiling tests with valgrind * fix 2 memory leaks (ImageCairo.cpp and FrameGkd.cpp) found by running valgrind
Geoffrey Garen
Comment 2 2006-10-09 16:04:02 PDT
Comment on attachment 10991 [details] linux/gdk build fixes; minor gdk improvements r=me
Mark Rowe (bdash)
Comment 3 2006-10-09 16:13:59 PDT
Landed in r16945. Thanks Krzysztof!
Note You need to log in before you can comment on or make changes to this bug.