Bug 11214 - http/tests/xmlhttprequest/exceptions.html needs new results
Summary: http/tests/xmlhttprequest/exceptions.html needs new results
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Adam Roben (:aroben)
URL: http://build.webkit.org/results/post-...
Keywords: EasyFix
Depends on:
Blocks:
 
Reported: 2006-10-08 02:22 PDT by Adam Roben (:aroben)
Modified: 2006-10-17 09:41 PDT (History)
3 users (show)

See Also:

Attachments
New results (1.65 KB, patch)
2006-10-08 02:23 PDT, Adam Roben (:aroben) 		no flags Details | Formatted Diff | Diff
Updated with comment as to why "FAIL" is the expected output (2.85 KB, patch)
2006-10-08 03:16 PDT, Adam Roben (:aroben) 		darin: review+
Details | Formatted Diff | Diff
Updated w/ better comment, removed "FAIL" from expected output (3.16 KB, patch)
2006-10-15 11:57 PDT, Adam Roben (:aroben) 		adele: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2006-10-08 02:22:40 PDT 
Change r16794 broke this test, and it needs new results.
Comment 1 Adam Roben (:aroben) 2006-10-08 02:23:22 PDT 
Created attachment 10974 [details]
New results
Comment 2 Adam Roben (:aroben) 2006-10-08 03:16:55 PDT 
Created attachment 10975 [details]
Updated with comment as to why "FAIL" is the expected output

Mitz suggested I add a comment explaining why "FAIL" is expected behavior for two tests.
Comment 3 Darin Adler 2006-10-08 07:01:47 PDT 
Comment on attachment 10975 [details]
Updated with comment as to why "FAIL" is the expected output

r=me
Comment 4 Darin Adler 2006-10-08 07:03:02 PDT 
The comment is not so great for people who don't have access to Radar. It would be better to write a comment that explains the reason a tiny bit (many Dashboard widgets will fail if we change the behavior).
Comment 5 Adam Roben (:aroben) 2006-10-15 11:57:44 PDT 
Created attachment 11098 [details]
Updated w/ better comment, removed "FAIL" from expected output

Hyatt and Mitz felt that we should not have "FAIL" in our expected results, so I've changed the test to remove this output. I also have cleared up the comments in the test per Darin's request.
Comment 6 Adam Roben (:aroben) 2006-10-17 09:41:52 PDT 
Landed as r17078