CLOSED FIXED 11195
add API to provide your own default favicon 
https://bugs.webkit.org/show_bug.cgi?id=11195
Summary add API to provide your own default favicon
Rachael Worthington (cheers)
Reported 2006-10-06 14:12:51 PDT
It would be handy to allow users to specify their own default favicon that goes with their UI, instead of being locked into the blue globe. It would be even nicer if we could then provide a different icon for graphite and aqua UI styles.
Attachments
Patch to add delegate (9.68 KB, patch)
2006-10-09 17:36 PDT, Brady Eidson 		sullivan: review-
DetailsFormatted DiffDiff
Lets pretend that last patch didn't happen, and lets be amazed it compiled (9.68 KB, patch)
2006-10-09 18:16 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Lets pretend I attached the right patch (9.69 KB, patch)
2006-10-09 18:18 PDT, Brady Eidson 		sullivan: review-
DetailsFormatted DiffDiff
Lets pretend I'm getting closer (10.31 KB, patch)
2006-10-09 18:53 PDT, Brady Eidson 		sullivan: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2006-10-09 17:26:07 PDT
After much consideration, and discussion with Rachael in #webkit, I think a good way to do this is to introduce a WebIconDatabaseDelegate to override the default icon behavior. This seems to fit will with common designs in the rest of WebKit. A patch is emmenent.
Brady Eidson
Comment 2 2006-10-09 17:36:11 PDT
Created attachment 11005 [details] Patch to add delegate
John Sullivan
Comment 3 2006-10-09 18:07:36 PDT
Comment on attachment 11005 [details] Patch to add delegate I talked with Brady on IRC and pointed out a few issues.
Brady Eidson
Comment 4 2006-10-09 18:16:40 PDT
Created attachment 11006 [details] Lets pretend that last patch didn't happen, and lets be amazed it compiled
Brady Eidson
Comment 5 2006-10-09 18:17:17 PDT
Comment on attachment 11006 [details] Lets pretend that last patch didn't happen, and lets be amazed it compiled nevermind, lets pretend I attached the correct patch
Brady Eidson
Comment 6 2006-10-09 18:18:01 PDT
Created attachment 11007 [details] Lets pretend I attached the right patch
John Sullivan
Comment 7 2006-10-09 18:36:30 PDT
Comment on attachment 11007 [details] Lets pretend I attached the right patch I gave Brady more comments on IRC.
Brady Eidson
Comment 8 2006-10-09 18:53:37 PDT
Created attachment 11008 [details] Lets pretend I'm getting closer
John Sullivan
Comment 9 2006-10-09 18:57:20 PDT
Comment on attachment 11008 [details] Lets pretend I'm getting closer Looking good!
Brady Eidson
Comment 10 2006-10-09 19:15:56 PDT
Commited in r16956
Brady Eidson
Comment 11 2006-10-09 19:17:12 PDT
Rachael - please verify and close :)
Rachael Worthington (cheers)
Comment 12 2006-10-10 20:32:47 PDT
works beautifully for OmniWeb. Thank you folks!!
Note You need to log in before you can comment on or make changes to this bug.