CLOSED FIXED 11192
[S60] Can not insert some characters in the Google search field
https://bugs.webkit.org/show_bug.cgi?id=11192
Summary [S60] Can not insert some characters in the Google search field
Zhaosong Lu
Reported 2006-10-06 12:24:59 PDT
When the format data saved enabled,character can not be inserted correctly. For example, the 'holland' is input as hmlljkand. For more information, please see the bug report ENVD-6RMFB7 in TSW.
Attachments
change for the fix of the bug (2.20 KB, patch)
2006-10-06 13:10 PDT, Zhaosong Lu
Sachin.Padma: review-
new patch containing change according to Sachin's comment (2.02 KB, patch)
2006-10-13 13:21 PDT, Zhaosong Lu
Sachin.Padma: review+
fix for 3.1 (2.03 KB, patch)
2006-10-16 13:39 PDT, Zhaosong Lu
Sachin.Padma: review+
Zhaosong Lu
Comment 1 2006-10-06 13:10:24 PDT
Created attachment 10953 [details] change for the fix of the bug When the form data saving is enabled, the CControlSelectWidget::FilterContentL is called whenever a 'letter' is inputed into an editbox. The function calls the the listbox's setFocus(). This setFocus triggers a CommitInlineEditL action in CAknFepManager. If users press keys in a 'normal' speed, there is no problem because there is nothing for committing. But if users press two keys very quickly, the second key will be commited by the SetFocus() of the first key and the cursor in the editbox will move to the third key position. The result is that it seems not letting you insert some key in the second position. The fix is to change the SetFocus call. We actually don't need the setfocus call. What we need is blue highlighting effect which can be achieved by calling the SetEmphasized().
Sachin Padma
Comment 2 2006-10-11 08:43:29 PDT
Comment on attachment 10953 [details] change for the fix of the bug The problem seems to me that we are calling UpdatePopup in HandleCompletionOfTransactionL which is called for every key input. We should do update popup only after the character has been commited
Zhaosong Lu
Comment 3 2006-10-13 13:21:51 PDT
Created attachment 11076 [details] new patch containing change according to Sachin's comment After discuss with Sachin, we think the setFocus call does not needed since the flag is false. It is also because the listbox will have the focus when it gets the key event.
Sachin Padma
Comment 4 2006-10-13 14:48:14 PDT
Comment on attachment 11076 [details] new patch containing change according to Sachin's comment r=me
Sachin Padma
Comment 5 2006-10-13 14:50:44 PDT
committed as r17045
Zhaosong Lu
Comment 6 2006-10-16 13:39:49 PDT
Created attachment 11116 [details] fix for 3.1 This is the same change for 3.1.
Sachin Padma
Comment 7 2006-10-18 10:52:39 PDT
Comment on attachment 11116 [details] fix for 3.1 r=me
Sachin Padma
Comment 8 2006-10-18 11:00:39 PDT
committed as r17110 to 3.1m
Krishna
Comment 9 2006-10-27 18:17:10 PDT
S60WebKitTrunkSDK\20061027161039 Also Closed.
Note You need to log in before you can comment on or make changes to this bug.