Bug 11115 - REGRESSION: Crash on Flickr after hitting cancel from adding a note
Summary: REGRESSION: Crash on Flickr after hitting cancel from adding a note
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Major
Assignee: Nobody
URL: http://flickr.com/photos/72597092@N00...
Keywords: HasReduction, InRadar, Regression
Depends on:
Blocks:
 
Reported: 2006-10-01 23:43 PDT by Mark Rowe (bdash)
Modified: 2007-01-20 17:02 PST (History)
1 user (show)

See Also:


Attachments
Crash log (22.47 KB, text/plain)
2006-10-01 23:44 PDT, Mark Rowe (bdash)
no flags Details
Reduction (will crash) (317 bytes, text/html)
2006-10-21 06:35 PDT, mitz
no flags Details
Fix (4.14 KB, patch)
2007-01-20 14:41 PST, mitz
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2006-10-01 23:43:10 PDT
Steps to reproduce:
1) Visit URL.
2) Hit the "Add Note" button.
3) Hit cancel.
4) *boom*
Comment 1 Mark Rowe (bdash) 2006-10-01 23:44:37 PDT
Created attachment 10861 [details]
Crash log
Comment 2 tim bates 2006-10-13 14:24:10 PDT
is note "comment"? if so this doesn't have a cancel button and works fine.

if not, can you explain more what to do?

Also, step 1.5 is log into flickr with a valid flickr or yahoo account
Comment 3 Mark Rowe (bdash) 2006-10-13 17:59:15 PDT
No, "Add Note" is "Add Note", exactly as I said.  I'm not sure under what circumstances this button is visible but it may require that you're looking at a "friends" image.
Comment 4 mitz 2006-10-21 06:35:47 PDT
Created attachment 11175 [details]
Reduction (will crash)

What a mess. Since the textarea contains the selection (thanks to focus()), Document::updateRendering() is invoked under setInnerText. Because of the style change, this deletes the inner div whose text is being set, and things just go downhill from there.
Comment 5 Stephanie Lewis 2006-11-08 14:22:55 PST
radar 4826741
Comment 6 mitz 2007-01-20 14:41:09 PST
Created attachment 12576 [details]
Fix
Comment 7 Maciej Stachowiak 2007-01-20 15:08:48 PST
Comment on attachment 12576 [details]
Fix

r=me
Comment 8 Sam Weinig 2007-01-20 17:02:50 PST
Landed in r19006.