Bug 11112 - add a drop shadow to the hand cursor used for links
Summary: add a drop shadow to the hand cursor used for links
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-01 20:49 PDT by Lars Næsbye Christensen
Modified: 2007-01-15 21:06 PST (History)
0 users

See Also:


Attachments
Patch to replace local TIFF cursor with NSCursor (482 bytes, patch)
2006-10-01 20:51 PDT, Lars Næsbye Christensen
timothy: review-
Details | Formatted Diff | Diff
adds dropshadow to link cursor (1.14 KB, patch)
2007-01-10 20:01 PST, Lars Næsbye Christensen
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Næsbye Christensen 2006-10-01 20:49:39 PDT
There is no point in loading our own link cursor, when AppKit supplies it through [NSCursor pointingHandCursor]
Comment 1 Lars Næsbye Christensen 2006-10-01 20:51:06 PDT
Created attachment 10858 [details]
Patch to replace local TIFF cursor with NSCursor
Comment 2 Lars Næsbye Christensen 2006-10-03 18:17:18 PDT
Comment on attachment 10858 [details]
Patch to replace local TIFF cursor with NSCursor 

Replaces the locally loaded TIFF pointing hand cursor with the system-supplied NSCursor
Comment 3 Timothy Hatcher 2006-10-03 19:56:29 PDT
Comment on attachment 10858 [details]
Patch to replace local TIFF cursor with NSCursor 

Our cursor has more demension than the built in cursor. We have a radar tracking this: <rdar://problem/4592353>
Comment 4 Lars Næsbye Christensen 2006-11-02 11:43:22 PST
(In reply to comment #3)
> (From update of attachment 10858 [details] [edit])
> Our cursor has more demension than the built in cursor. We have a radar
> tracking this: <rdar://problem/4592353>
> 

OK, I suppose we could remove the FIXME comment then :-)
Comment 5 Lars Næsbye Christensen 2007-01-10 20:01:34 PST
Created attachment 12353 [details]
adds dropshadow to link cursor

(In reply to comment #3)

> Our cursor has more demension than the built in cursor.

I agree wholeheartedly. And why not set the standards ourselves?
So here's a linkCursor with a slight drop shadow in it, like the arrow, alias and copy cursors. Maybe Apple will eventually backport it to Cocoa, so we can use it from there :-P
Comment 6 Darin Adler 2007-01-15 08:55:30 PST
Comment on attachment 12353 [details]
adds dropshadow to link cursor

Without the white outline that the arrow cursor has, I think the drop shadow is a very subtle effect. Probably too subtle for anyone to notice.

On the other hand, it does look slightly better, so r=me.

When landing, please mention in the change log what's different about the cursor!

And don't include the "WARNING: NO TEST CASES ADDED OR CHANGED".

And please retitle this bug if it's going to be cited in the change log.
Comment 7 Darin Adler 2007-01-15 21:04:29 PST
Committed revision 18878.