Bug 11092 - Windows build busted
Summary: Windows build busted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 420+
Hardware: PC Windows XP
: P2 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-29 15:34 PDT by Darin Fisher (:fishd, Google)
Modified: 2006-09-29 18:54 PDT (History)
0 users

See Also:

Attachments
patch (1.61 KB, patch)
2006-09-29 15:39 PDT, Darin Fisher (:fishd, Google) 		mjs: review+
Details | Formatted Diff | Diff
patch per hyatt (1.87 KB, patch)
2006-09-29 18:13 PDT, Darin Fisher (:fishd, Google) 		adele: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2006-09-29 15:34:29 PDT 
Windows build busted

Problems with ScrollViewWin.cpp referencing an undefined variable and Widget having undefined symbols.

Patch coming up...
Comment 1 Darin Fisher (:fishd, Google) 2006-09-29 15:39:54 PDT 
Created attachment 10841 [details]
patch

This fixes the build bustage.  I went for "#if !PLATFORM(MAC)" in Widget.cpp since the code should work for all other platforms.  I can also move the code into WidgetWin.cpp if that is preferred.
Comment 2 Maciej Stachowiak 2006-09-29 16:39:09 PDT 
Comment on attachment 10841 [details]
patch

r=me
Comment 3 Dave Hyatt 2006-09-29 16:42:05 PDT 
Actually should just move that code into WidgetWin.cpp rather than leaving it in Widget
Comment 4 Darin Fisher (:fishd, Google) 2006-09-29 18:13:47 PDT 
Created attachment 10843 [details]
patch per hyatt

OK, this patch simply moves the methods to WidgetWin.cpp as recommended by hyatt.  I did not complete the other changes he suggested over IRC, but I didn't want to leave the tree broken, so I'm posting this simple patch.