RESOLVED FIXED 11020
REGRESSION: No-SVG build broken since r16549 
https://bugs.webkit.org/show_bug.cgi?id=11020
Summary REGRESSION: No-SVG build broken since r16549
Graham Dennis
Reported 2006-09-25 05:31:48 PDT
From the build-bot: CompileC /Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/ppc/FrameView.o /Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebCore/page/FrameView.cpp normal ppc c++ com.apple.compilers.gcc.4_0 cd /Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebCore /usr/bin/gcc-4.0 -x c++ -arch ppc -pipe -Wno-trigraphs -fno-exceptions -fno-rtti -fpascal-strings -fasm-blocks -gfull -O2 -Werror -Wnon-virtual-dtor -Wnewline-eof -DNDEBUG -fmessage-length=0 -mtune=G5 -fvisibility-inlines-hidden -fno-threadsafe-statics -Wno-invalid-offsetof -mmacosx-version-min=10.4 -I/Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebKitBuild/WebCore.build/Release/WebCore.build/WebCore.hmap -Wall -W -Wcast-align -Wchar-subscripts -Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-format-y2k -Wno-unused-parameter -Wno-long-double -Wundef -Wshorten-64-to-32 -F/Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebKitBuild/Release -I/Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebKitBuild/Release/include -IForwardingHeaders -I. -Iicu -I/usr/include/libxslt -I/usr/include/libxml2 -I/Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebKitBuild/Release/DerivedSources/WebCore -I/Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebKitBuild/WebCore.build/Release/WebCore.build/DerivedSources -include /Library/Caches/com.apple.Xcode.502/SharedPrecompiledHeaders/WebCorePrefix-eitivqzvgdsjxidjzlxdczyozvwx/WebCorePrefix.h -c /Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebCore/page/FrameView.cpp -o /Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/ppc/FrameView.o /Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebCore/page/FrameView.cpp:51:5: error: "SVG_SUPPORT" is not defined /Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebCore/page/FrameView.cpp:62:5: error: "SVG_SUPPORT" is not defined /Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebCore/page/FrameView.cpp:664:5: error: "SVG_SUPPORT" is not defined ** BUILD FAILED ** The new #if SVG_SUPPORT lines added in r16549 should be #ifdefs (See bug #10896)
Attachments
patch (3.67 KB, patch)
2006-09-25 07:20 PDT, Graham Dennis 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Graham Dennis
Comment 1 2006-09-25 06:29:55 PDT
Regression -> p1
Graham Dennis
Comment 2 2006-09-25 07:20:28 PDT
Created attachment 10757 [details] patch Patch. Changes #if SVG_SUPPORT to #ifdef SVG_SUPPORT.
mitz
Comment 3 2006-09-25 14:21:27 PDT
Comment on attachment 10757 [details] patch r=me
Mark Rowe (bdash)
Comment 4 2006-09-26 04:29:13 PDT
Landed as r16571.
Note You need to log in before you can comment on or make changes to this bug.