RESOLVED FIXED 11009
Auto-generate the internal methods interfaces for the Objective-C bindings 
https://bugs.webkit.org/show_bug.cgi?id=11009
Summary Auto-generate the internal methods interfaces for the Objective-C bindings
Sam Weinig
Reported 2006-09-24 08:31:57 PDT
Patch to generate the interface declarations for the internal methods forthcoming.
Attachments
patch (94.52 KB, patch)
2006-09-24 08:39 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
patch 2 (92.87 KB, patch)
2006-09-24 08:42 PDT, Sam Weinig 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2006-09-24 08:39:00 PDT
Created attachment 10739 [details] patch - Auto-generate the internal method declarations into their own files named in the form DOMFooBarInternal.h for class DOMFooBar. - Remove all use of DOM_cast from code. - Assorted cleanups.
Sam Weinig
Comment 2 2006-09-24 08:42:27 PDT
Created attachment 10740 [details] patch 2 Removed a file that was not supposed to be included in the last patch
Timothy Hatcher
Comment 3 2006-09-24 12:19:57 PDT
Comment on attachment 10740 [details] patch 2 This looks good except one change: -    removeWrapperForRGB(reinterpret_cast<uintptr_t>(_internal));   +    removeWrapperForRGB(reinterpret_cast<WebCore::RGBA32>(_internal)); I made this change originally to uintptr_t so building for 64-bit would work. You will get a warning about truncating a 64-bit point to a 32-bit value if you use WebCore::RGBA32. r=me if you revert the changes in DOMRGBColor.mm.
Timothy Hatcher
Comment 4 2006-09-24 12:28:59 PDT
Comment on attachment 10740 [details] patch 2 Sam reverted DOMRGBColor.mm, he will not land that part. the rest is fine.
Sam Weinig
Comment 5 2006-09-24 13:31:26 PDT
Landed in r16548.
Note You need to log in before you can comment on or make changes to this bug.