Bug 10989 - Provide a way for embedders to implement BrowserExtensionWin
Summary: Provide a way for embedders to implement BrowserExtensionWin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 420+
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-22 13:11 PDT by Brett Wilson (Google)
Modified: 2006-10-05 13:27 PDT (History)
0 users

See Also:

Attachments
Patch to forward to the UIDelegate (9.72 KB, patch)
2006-10-02 14:19 PDT, Brett Wilson (Google) 		darin: review+
Details | Formatted Diff | Diff
Patch with changelog (13.43 KB, patch)
2006-10-05 11:13 PDT, Brett Wilson (Google) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brett Wilson (Google) 2006-09-22 13:11:32 PDT 
Important things like window.open() are provided by the interface BrowserExtensionWin. All functions in this class on Windows are currently stubbed out in TemporaryLinkStubs. There should be a way for embedders to provide implementations of these things.
Comment 1 Brett Wilson (Google) 2006-10-02 14:19:55 PDT 
Created attachment 10873 [details]
Patch to forward to the UIDelegate

This patch is based on DarinA and Maciej's help.

This adds a new file for BrowserExtensionWin where the TemporaryLinkStubs functions have been moved, and hooks up the createNewWindow calls (the rest remain the same stubs as in TemporaryLinkStubs). They are forwarded to the FrameWin, which then forwards them to the WebFrame. The WebFrame then calls the UIDelegate (if any) provided by the embedder.

The IDL declaration of the retval of IWebUIDelegate::createWebViewWithRequest seemed to be incorrect, so this also fixes that.
Comment 2 Darin Adler 2006-10-02 19:37:17 PDT 
Comment on attachment 10873 [details]
Patch to forward to the UIDelegate

Looks fine. r=me
Comment 3 Brett Wilson (Google) 2006-10-05 11:13:57 PDT 
Created attachment 10931 [details]
Patch with changelog
Comment 4 Alexey Proskuryakov 2006-10-05 13:27:28 PDT 
Committed revision 16817.